Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong charset used in creating search terms when server supports UTF8 #474

Open
axandar opened this issue Aug 30, 2020 · 2 comments · May be fixed by eclipse-ee4j/angus-mail#131
Open

Wrong charset used in creating search terms when server supports UTF8 #474

axandar opened this issue Aug 30, 2020 · 2 comments · May be fixed by eclipse-ee4j/angus-mail#131
Assignees
Labels
bug Something isn't working

Comments

@axandar
Copy link

axandar commented Aug 30, 2020

Describe the bug
Function int[] search(String msgSequence, SearchTerm term) throws ProtocolException, SearchException on line 2479 in IMAPProtocol class checks if server support UTF8.
In function private int[] issueSearch(String msgSequence, SearchTerm term, String charset) throws ProtocolException, SearchException, IOException on line 2532 Argument object is created with charset as null.

When null is passed to SearchSequence#generateSequence() it defaults to all ASCII text while parsing strings in seach terms.

I don't know if reproduction is needed here.

@lukasj
Copy link
Contributor

lukasj commented Jan 13, 2021

simple reproducer and/or test for this would be appreciated as the code path itself may not be clear and straightforward to newcomers to this project...

@jmehrens
Copy link
Contributor

jmehrens commented Jan 23, 2024

Looks like PR #607 is was created by another user for this issue. From what I can tell the PR looks correct but need to review it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants