fix typo indicated in #234 #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Santos Izaguirre <[email protected]>
lukasj
reviewed
Feb 17, 2024
| @@ -144,7 +144,7 @@ | |||
| * that doesn't have {@link XmlRootElement}. But they can't show up in an | |||
| * XML instance (because they don't have XML element names). | |||
| * | |||
| * <p><b>Example 2: XML Schema Susbstitution group support</b> | |||
| * <p><b>Example 2: XML Schema substitution group support</b> | |||
There was a problem hiding this comment.
first letter should be kept in upper case
There was a problem hiding this comment.
Fixed. However, At first commit I copied same format than line 37. Check it out and say to me if it is necessary to fix too.
Regards,
Antonio.
There was a problem hiding this comment.
the best would be to bring in consistency accross all usages ;-)
There was a problem hiding this comment.
Fixed in XmlElementDecl too!
Signed-off-by: Antonio Santos Izaguirre <[email protected]>
lukasj
approved these changes
Feb 18, 2024
|
btw: same/similar typos are there in XmlElementDecl - can you fix it all at once? |
Signed-off-by: Antonio Santos Izaguirre <[email protected]>
lukasj
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lukasj
I wish this PR would be useful for the project.
Regards,
Antonio.