Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #267, migrating JUnit 4 to JUnit 5 #292

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix #267, migrating JUnit 4 to JUnit 5 #292

wants to merge 3 commits into from

Conversation

antoniosanct
Copy link
Contributor

@antoniosanct antoniosanct commented Feb 16, 2024 •
edited
Loading

@lukasj
I wish this PR would be useful for the project.

Regards,
Antonio.

@antoniosanct
fix jakartaee#267, migrating JUnit 4 to JUnit 5
77f536f 
Signed-off-by: Antonio Santos Izaguirre <[email protected]>
@antoniosanct
copyright to scenarios file
f1ac071 
Signed-off-by: Antonio Santos Izaguirre <[email protected]>
lukasj
lukasj reviewed Feb 17, 2024
View reviewed changes
Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait with this after 4.0.2 gets out

@lukasj lukasj linked an issue Feb 18, 2024 that may be closed by this pull request
Tests fail with module resolution exception #267
Open
@antoniosanct antoniosanct mentioned this pull request Feb 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasj lukasj lukasj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail with module resolution exception
2 participants
@antoniosanct @lukasj