Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use https for w3 locations #39

Open
ivargrimstad opened this issue Aug 2, 2022 · 5 comments · May be fixed by #40
Open

Use https for w3 locations #39

ivargrimstad opened this issue Aug 2, 2022 · 5 comments · May be fixed by #40
Assignees
@ivargrimstad @scottmarlow

Comments

@ivargrimstad
Copy link
Member

See jakartaee/jakarta.ee#1505
@ivargrimstad ivargrimstad mentioned this issue Aug 2, 2022
Closed
@ivargrimstad ivargrimstad self-assigned this Aug 2, 2022
@scottmarlow
Copy link

@ivargrimstad did you intend to update all xsd files or only EE 10 ones?

Output from grep -rli "http:.*www.w3.org" --include=*.xsd:

static/xml/ns/jaxws/wsdl_customizationschema_3_0.xsd
static/xml/ns/validation/validation-mapping-3.0.xsd
static/xml/ns/validation/validation-configuration-3.0.xsd
static/xml/ns/persistence/persistence_3_0.xsd
static/xml/ns/persistence/orm/orm_3_0.xsd
static/xml/ns/persistence/orm/orm_3_1.xsd
static/xml/ns/jaxb/bindingschema_3_0.xsd
static/xml/ns/jakartaee/web-app_6_0.xsd
static/xml/ns/jakartaee/web-partialresponse_3_0.xsd
static/xml/ns/jakartaee/batchXML_2_0.xsd
static/xml/ns/jakartaee/web-facelettaglibrary_3_0.xsd
static/xml/ns/jakartaee/ejb-jar_4_0.xsd
static/xml/ns/jakartaee/jakartaee_web_services_2_0.xsd
static/xml/ns/jakartaee/web-facelettaglibrary_4_0.xsd
static/xml/ns/jakartaee/application_9.xsd
static/xml/ns/jakartaee/connector_2_1.xsd
static/xml/ns/jakartaee/web-fragment_6_0.xsd
static/xml/ns/jakartaee/web-common_5_0.xsd
static/xml/ns/jakartaee/web-partialresponse_4_0.xsd
static/xml/ns/jakartaee/web-common_6_0.xsd
static/xml/ns/jakartaee/jakartaee_9.xsd
static/xml/ns/jakartaee/web-jsptaglibrary_3_1.xsd
static/xml/ns/jakartaee/web-facesconfig_4_0.xsd
static/xml/ns/jakartaee/application-client_9.xsd
static/xml/ns/jakartaee/web-facesconfig_3_0.xsd
static/xml/ns/jakartaee/beans_4_0.xsd
static/xml/ns/jakartaee/jakartaee_web_services_metadata_handler_3_0.xsd
static/xml/ns/jakartaee/web-jsptaglibrary_3_0.xsd
static/xml/ns/jakartaee/application-client_10.xsd
static/xml/ns/jakartaee/web-fragment_5_0.xsd
static/xml/ns/jakartaee/jsp_3_1.xsd
static/xml/ns/jakartaee/web-app_5_0.xsd
static/xml/ns/jakartaee/permissions_9.xsd
static/xml/ns/jakartaee/beans_3_0.xsd
static/xml/ns/jakartaee/connector_2_0.xsd
static/xml/ns/jakartaee/jobXML_2_0.xsd
static/xml/ns/jakartaee/jakartaee_web_services_client_2_0.xsd
static/xml/ns/jakartaee/application_10.xsd
static/xml/ns/jakartaee/jsp_3_0.xsd
static/xml/ns/jakartaee/permissions_10.xsd

@scottmarlow
Copy link

scottmarlow/jakarta.ee@f091b53 has just a static/xml/ns/jakartaee/jakartaee_10.xsd change but static/xml/ns/jakartaee/jakartaee_9.xsd also has a similar w3 http reference (and other files as well).

@ivargrimstad
Copy link
Member Author

ivargrimstad commented Aug 3, 2022 •
edited
Loading

I started digging a little into this, and I am not so sure changing anything would actually help. The w3-schemas we are referencing have HTTP refs internally. And we are not allowed to change those. So we would essentially just be kicking the ball down one row...

@pzygielo
Copy link

pzygielo commented Aug 3, 2022 •
edited
Loading

I started digging a little into this

perhaps too deep

and I am not so sure changing anything would actually help. The w3-schemas we are referencing have HTTP refs internally. And we are not allowed to change those. So we would essentially just be kicking the ball down one row...

Just changing xsd:import/schemaLocation for example
https://github.com/eclipse-ee4j/jakartaee-schemas/blob/c1178755c94725cc002732c25f5b601b6057a222/xml/src/jakartaee_10.xsds#L41-L42
actually helps (in my case), like in

No need to change namespaces or other references, but import instruction uses direct link to resource.

With above, grep -ri "http:.*www.w3.org" --include=*.xsd| grep schemaLocation only lists

xml/ns/jakartaee/jakartaee_9.xsd:              schemaLocation="http://www.w3.org/2001/xml.xsd"/>
xml/ns/jakartaee/jakartaee_10.xsd:              schemaLocation="http://www.w3.org/2001/xml.xsd"/>

@ivargrimstad
Copy link
Member Author

Thanks @pzygielo
That sounds doable. I'll get it done right away

@ivargrimstad ivargrimstad linked a pull request Aug 3, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivargrimstad ivargrimstad

@scottmarlow scottmarlow

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ivargrimstad @scottmarlow @pzygielo