-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new TCK tests for 5.0 #1852
base: 5.0
Are you sure you want to change the base?
Conversation
TODO: this isn't working, GlassFish 7 throws OSGI exception that Faces SPI cannot be higher than 5.0.0
After bumping to GF 7.0.10 it now throws
|
I don't know about 7.0.10. but in general GlassFish (via OSGi/Felix) has automatic protection enabled against updating anything by a major version. This protection is in META-INF/MANIFEST.MF of each jar via a version range. E.g.
[...]
You can edit the MANIFEST.MF files manually in each jar, or build GlassFish with an updated pom.xml for the new versions. |
It is a default behavior of OSGI (maven felix plugin). It can be overriden, but increasing major version number usually means "breaking changes". And because OSGI is quite restrictive and respects also transitive dependencies, it causes many issues. |
Still failing with 8.0.0-JDK17-M7.
Still unclear how to bypass from app on, I've never really worked with OSGI before. We basically cannot add/run TCKs for Faces 5.0 until a GlassFish version is available implementing Faces 5.0. Feels like chicken-egg. |
faces_issue_1713_add_new_tck
…o faces_issue_1443_add_new_tck
Note that TCK doesn't work yet hence in separate branch/PR
Can anyone please help me sorting out this? This is blocking me from being able to develop new TCK tests for 5.0 because I'm unable to run them in order to verify if they work fine. |
Can anyone please help me sorting out this? This is blocking me from being able to develop new TCK tests for 5.0 because I'm unable to run them in order to verify if they work fine. This has been stuck since October 2023. Please help me moving forward this. This is one of main reasons Faces 5.0 couldn't move on for EE11 and we were stuck with 4.1. We don't want another 4.2 situation again. |
New TCK tests for:
TODO: this isn't working, GlassFish 7 basically complains Mojarra version can't be 5.0.0 or higher.
Can you please take a look @arjantijms