Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using XY Plot and "XY Input: Checkpoint", "optional_vae" input on KSampler (Efficient) is ignored #273

Open
Targren opened this issue Jan 3, 2025 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Targren
Copy link

Targren commented Jan 3, 2025

This gets to be a a problem when one of the selected checkpoints doesn't have a baked VAE, etc. The VAE from the "Efficiency Loader" that ends up in the "SCRIPT" output gets used regardless of what's fed into the KSampler (Efficient) input, though one might expect that connecting the optional input would be the overriding VAE.

In the example image/workflow attached, If you load an SDXL model in the plot with an SD 1.5 VAE (to make it obvious where it's using the wrong vae), and select the SDXL VAE in the loader connected to the "optional_vae" input, it demonstrates what's going on. The latter uses a VAE Decode node instead - it works, but if you don't let the KSampler do the decoding, you don't get the XY Grid.

Disconnecting the "Dependencies" wire from Loader to XY Plot node fixes the VAE issue, but it also keeps the grid from generating, just like bypassing the decode on the KSampler, the plot script seems to be the culprit.

Update: Looking at the code (and confirming in the workflow) this morning - even more strangely, connecting an "optional_vae" is required when doing an XY plot.

VAETEST_NoGrid_00003_

@jags111 jags111 self-assigned this Jan 8, 2025
@jags111 jags111 added the documentation Improvements or additions to documentation label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants