Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output correctly-timed waveforms #47

Open
4 tasks
jacopok opened this issue Nov 9, 2022 · 0 comments
Open
4 tasks

Output correctly-timed waveforms #47

jacopok opened this issue Nov 9, 2022 · 0 comments
Assignees
Labels

Comments

@jacopok
Copy link
Owner

jacopok commented Nov 9, 2022

Currently, waveforms are output with a shift in time compared to their EOB counterparts.
This was acceptable in earlier versions of the software, but it is not anymore, since we are trying to build a combined inspiral-postmerger model by hybridizing with NRPMw.

The approach is as follows: instead of computing the residuals in phase and flattening them by an arbitrary amount,
we almost flatten them by shifting the waveforms by an amount determined by a fit to the timeshifts at hand,
which was done by Matteo here.

So, the steps to take are:

  • include the time shift by the fit amount both in the generation of the training dataset (removing the flattening) and in the reconstruction
  • include the fit in mlgw-bns (function ParamsWithExtrinsic -> float)
  • test it
  • remove the possibility to shift in time when computing mismatches from existing tests (expecting a failure)
@jacopok jacopok self-assigned this Nov 9, 2022
@jacopok jacopok added the enhancement New feature or request label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant