Node spawn causes issues with Windows. Replace with cross-spawn. #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failing for older versions of node. Looks like the 0.4 failure is build env specific, the other failures could be solved by changing cross-spawn versions. Will wait for advice from @jacobrask. |
|
Closing due to age. Over 2 years old. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #121.
The errors stem from node's child_process.spawn ignoring PATH_EXT in Windows. See more details here: nodejs/node-v0.x-archive#2318. Replacing the native spawn with cross-spawn fixes these issues and is a more portable way of approaching the problem than attempting to append the appropriate extension to the preprocessor depending on the environment.
NOTE: On older versions of node (I believe < 0.12) this non-breaking warning comes along with cross-spawn: