Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

long_panel suddenly got super slow #51

Open
tci1 opened this issue Dec 18, 2022 · 3 comments
Open

long_panel suddenly got super slow #51

tci1 opened this issue Dec 18, 2022 · 3 comments

Comments

@tci1
Copy link

tci1 commented Dec 18, 2022

I'd been using the long_panel function on a couple datasets just fine. I had to do some updates (packages, RStudio, R). When I run long_panel in the 'panelr' package now it suddenly takes a really long time. Like what took 1-2 minutes before is not taking >17 minutes. It just runs and runs and won't finish. I have to hit Esc. Any suggestions?

@jacob-long
Copy link
Owner

I'm experiencing the same thing. Investigating now...

@jacob-long
Copy link
Owner

After spending too much time looking into this, in my tests the part of the function that takes almost all of the runtime is deeply nested inside a tidyverse function. After looking at some of my old notes, I'm no longer confident that it has gotten slower on the package's own examples, which is all I have to work with for now.

If I find another example with a different bottleneck, I will revisit. I'm also considering giving the user better options to opt out of the slow part of the function if they know enough about their data to avoid needing that part.

@tci1
Copy link
Author

tci1 commented Jan 14, 2023 via email

jacob-long added a commit that referenced this issue Feb 2, 2023
Does not improve benchmarks for #51 unfortunately
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants