-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
long_panel suddenly got super slow #51
Comments
I'm experiencing the same thing. Investigating now... |
After spending too much time looking into this, in my tests the part of the function that takes almost all of the runtime is deeply nested inside a tidyverse function. After looking at some of my old notes, I'm no longer confident that it has gotten slower on the package's own examples, which is all I have to work with for now. If I find another example with a different bottleneck, I will revisit. I'm also considering giving the user better options to opt out of the slow part of the function if they know enough about their data to avoid needing that part. |
Thanks for the update. The options to opt out of a part sound nice.
Thanks for a great package! There's so much to love about it!
…On Thu, Jan 12, 2023 at 7:33 AM Jacob Long ***@***.***> wrote:
After spending too much time looking into this, in my tests the part of
the function that takes almost all of the runtime is deeply nested inside a
tidyverse function. After looking at some of my old notes, I'm no longer
confident that it has gotten slower on the package's own examples, which is
all I have to work with for now.
If I find another example with a different bottleneck, I will revisit. I'm
also considering giving the user better options to opt out of the slow part
of the function if they know enough about their data to avoid needing that
part.
—
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A427LQN4P7ULSHW4NMSPMMDWSABZTANCNFSM6AAAAAATCU3FS4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Does not improve benchmarks for #51 unfortunately
I'd been using the long_panel function on a couple datasets just fine. I had to do some updates (packages, RStudio, R). When I run long_panel in the 'panelr' package now it suddenly takes a really long time. Like what took 1-2 minutes before is not taking >17 minutes. It just runs and runs and won't finish. I have to hit Esc. Any suggestions?
The text was updated successfully, but these errors were encountered: