Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dependencies on older versions #8

Open
KeiichiHirobe opened this issue Jul 13, 2021 · 0 comments
Open

Delete dependencies on older versions #8

KeiichiHirobe opened this issue Jul 13, 2021 · 0 comments

Comments

@KeiichiHirobe
Copy link

I want to delete dependencies on github.com/satori/go.uuid because it is vulnerable.

# master branch of https://github.com/jackc/pgx
$ pwd
/home/go/src/github.com/pgx
$ go mod graph | grep satori
github.com/jackc/[email protected] github.com/satori/[email protected]
github.com/jackc/pgx/[email protected] github.com/satori/[email protected]
github.com/jackc/[email protected] github.com/satori/[email protected]
github.com/jackc/pgx/[email protected] github.com/satori/[email protected]
github.com/jackc/[email protected] github.com/satori/[email protected]
github.com/jackc/pgx/[email protected] github.com/satori/[email protected]

But, maybe we cannot do that because there are cyclic dependencies between modules as below(this is part of go mod graph outputs) .

github.com/jackc/pgx/v4 ->
github.com/jackc/[email protected] ->
github.com/jackc/[email protected] ->
github.com/jackc/[email protected] ->
github.com/jackc/[email protected] ->
github.com/satori/[email protected]

github.com/jackc/pgmock depends on github.com/jackc/pgconn, and vice versa.
github.com/jackc/pgx depends on github.com/jackc/pgtype, and vice versa.

I don't fully understand, but I think we cannot delete dependencies on older versions completely even if update module like #5.

Am I right?
If yes, do you have any plan to resolve this?

Related Issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant