Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean code: splits model-view #2

Open
jaapandre opened this issue Jan 30, 2012 · 2 comments
Open

clean code: splits model-view #2

jaapandre opened this issue Jan 30, 2012 · 2 comments
Assignees
Milestone

Comments

@jaapandre
Copy link
Owner

code and views are mixed up, should be cleaned, also more functions to generate for example the result preview

@ghost ghost assigned jaapandre Jan 30, 2012
@Potherca
Copy link
Collaborator

I've already refactored the code to only do a single echo. It's a small step to get things separated from there.
I was thinking of just moving all markup to a separate HTML file, loading that as a DOMDocument and manipulating nodes from there (although that would make the code PHP5 only... hope that's not a problem...)

This step would also include having the styles in a separate CSS file.
(and probably putting the header in a div instead of a table... but that's a different matter entirely)

@jaapandre
Copy link
Owner Author

Hi, that would be nice. Please send a pull request. I like to try that, but I'll add you as collaborator later on.
php 5 is not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants