Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement from_dict in Embedding class #1

Open
jaARke opened this issue Jul 15, 2023 · 0 comments
Open

Implement from_dict in Embedding class #1

jaARke opened this issue Jul 15, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@jaARke
Copy link
Owner

jaARke commented Jul 15, 2023

The Embedding class currently provides a to_dict function for converting class data into a dictionary. It would be easy enough to add a function for the opposite conversion, and such a function might make it easier for users to create custom Embeddings, so long as they were made aware of the supported dictionary structure.

The from_dict function would be a static function that initializes an Embedding object from a dictionary parameter. This would require mapping dictionary fields to class attributes in the same way they are mapped in the to_dict function.

@jaARke jaARke added the enhancement New feature or request label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant