You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As far as I understand it's meant to be used as library for other projects. Project might load more complex configuration (file logging, emails, sentry, etc).
I like the way you're thinking about this. Looking forward to catching up with this idea.
On Wednesday, September 26, 2012 at 9:22 AM, Domantas wrote:
Projects are using logging module. Constructor should be left for program since logging might and will be used before constructing Brubeck class witch is just a plugin for program and then it causes bug that logging won't work at all - http://stackoverflow.com/questions/1943747/python-logging-before-you-run-logging-basicconfig
Will be submitting pull request shortly.
—
Reply to this email directly or view it on GitHub (#83 (comment)).
As far as I understand it's meant to be used as library for other projects. Project might load more complex configuration (file logging, emails, sentry, etc).
I would suggest leaving constructing logger for project not for library.
https://github.com/j2labs/brubeck/blob/master/brubeck/request_handling.py#L639
The text was updated successfully, but these errors were encountered: