Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix touch functionality in Edge #50

Closed
wants to merge 1 commit into from

Conversation

patrickkettner
Copy link

fixes #49

@@ -27,7 +27,7 @@ module.exports = function(grunt) {
header: '+function ($) {\n' +
' "use strict";\n' +
'\n' +
' if (!("ontouchstart" in window || navigator.msMaxTouchPoints)) return false \n\n',
' if (!("ontouchstart" in window || "PointerEvent" in window || navigator.msMaxTouchPoints)) return false \n\n',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use single quotes here 'PointerEvent'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to be clear, you want to use double quotes on "ontouchstart" and single quotes on \'PointerEvent\'?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrickkettner Oh dam it...didn't realize that! So all my comments below are obsolet. Sorry man ✌️

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem! Did you still want a changelog update?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that would be nice!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the changelog as well as the relevant version numbers.

@ixisio
Copy link
Owner

ixisio commented Aug 14, 2015

Can use also please add an changelog entry for for changes.

@ixisio
Copy link
Owner

ixisio commented Aug 14, 2015

hey @patrickkettner

Thank u very much for changes. I make you some minor comments. Would u please fix it so I can merge it quickly.

Cheers
Andy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Touch functionality does not work in Microsoft Edge
2 participants