-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix touch functionality in Edge #50
Conversation
@@ -27,7 +27,7 @@ module.exports = function(grunt) { | |||
header: '+function ($) {\n' + | |||
' "use strict";\n' + | |||
'\n' + | |||
' if (!("ontouchstart" in window || navigator.msMaxTouchPoints)) return false \n\n', | |||
' if (!("ontouchstart" in window || "PointerEvent" in window || navigator.msMaxTouchPoints)) return false \n\n', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use single quotes here 'PointerEvent'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to be clear, you want to use double quotes on "ontouchstart"
and single quotes on \'PointerEvent\'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patrickkettner Oh dam it...didn't realize that! So all my comments below are obsolet. Sorry man ✌️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no problem! Did you still want a changelog update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that would be nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the changelog as well as the relevant version numbers.
Can use also please add an changelog entry for for changes. |
hey @patrickkettner Thank u very much for changes. I make you some minor comments. Would u please fix it so I can merge it quickly. Cheers |
fixes #49