Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Link in Carousel' issue #4

Open
naderby opened this issue Nov 19, 2013 · 6 comments
Open

'Link in Carousel' issue #4

naderby opened this issue Nov 19, 2013 · 6 comments
Assignees
Labels

Comments

@naderby
Copy link

naderby commented Nov 19, 2013

I have links inside the bootstrap carousel panels and these can be clicked through on all devices I've tried except for Kindle when using bootstrap-touch-carousel.

I can confirm this by removing the script and the links will then work.

The links show that they have been pressed but nothing happens. However, if you hold the link button then the pop up will show the link navigation options, eg. open in new tab etc.

Otherwise a fine script!

@ghost ghost assigned ixisio Nov 20, 2013
@ixisio
Copy link
Owner

ixisio commented Nov 20, 2013

hey @naderby,
will have a look on it very soon.

I think, gestures are fully supported on Kindle fire.
But you are talking about links inside captions?

thx!

Cheers,
andy

@naderby
Copy link
Author

naderby commented Nov 20, 2013

This is the HTML I'm using:

<div class="item active">
    <a href="/page-1/" class="one"></a>
    <div class="carousel-caption">
        <h2 class="hidden-xs">Title</h2>
        <p class="hidden-xs">Content.</p>
        <p><a href="/page-1/" class="btn btn-default">Button</a></p>
    </div>
</div>

@ixisio
Copy link
Owner

ixisio commented Dec 3, 2013

you can try to remove the .prevent-user-select() Mixin. Maybe this would help.

It's not possible for me to test on a real kindle device, so you have to try-and-error a bit for yourself.

Anybody any idea?

Sorry & Cheers

@naderby
Copy link
Author

naderby commented Dec 16, 2013

I can confirm this also happens on the Nexus 7 with Jellybean, using my code as above.

I will be trying the remove mixin experiment shortly.

@naderby
Copy link
Author

naderby commented Dec 16, 2013

I gave the div.carousel.slide.touch-carousel a style of "-webkit-user-select: auto !important" to override the mixin and the problem remained.

Oddly, on the nexus, although the link didn't work if you hold a finger down the resulting options presented suggest the browser does know that it is a link: Open Link In New Tab etc

@ixisio
Copy link
Owner

ixisio commented Dec 16, 2013

hmm, sounds like a click/touch event .preventDefault().
I'll take care of it very soon...

@ixisio ixisio added the bug label Feb 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants