Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Carousel inside a modal #21

Open
thecodingwhale opened this issue Mar 25, 2014 · 12 comments
Open

Bug: Carousel inside a modal #21

thecodingwhale opened this issue Mar 25, 2014 · 12 comments
Labels
Milestone

Comments

@thecodingwhale
Copy link

I need to click first the next or previous button in order the touch event to work,

@ixisio
Copy link
Owner

ixisio commented Jun 10, 2014

@thecodingwhale i don't know how to reproduce this behaviour?

@ixisio
Copy link
Owner

ixisio commented Jul 22, 2014

is this issue still relevant?

@ixisio ixisio added the bug label Jul 22, 2014
@pierrefaure
Copy link

Hello,
I had the same issue and I have found that my data-ride="carousel" was missing in the div of my carousel.

It works well with the data-ride attribute.

BTW, thank you for your awesome plugin 👍

@ixisio
Copy link
Owner

ixisio commented Jul 22, 2014

hey @pierrefaure, appreciate your feedback!
have you test the plugin to work inside a modal?

@pierrefaure
Copy link

Hi,
My carousel isn't inside a modal. My bad I have read the title too quickly :)
(but my issue was the same than described above)

@ixisio
Copy link
Owner

ixisio commented Jul 25, 2014

@thecodingwhale any way to describe how other people could reproduce this bug?

@thecodingwhale
Copy link
Author

@ixisio those things happened with I try to put the carousel inside a modal. I need to trigger first the next or previous event before the touch event work.

@ixisio
Copy link
Owner

ixisio commented Aug 8, 2014

@thecodingwhale the DOM of the carousel is not rendered initially, so IMO the onDocumentReady event of the carousel fires but no carousel slides are in the current document. Are you generate the Modal with javascript on the fly?

@thecodingwhale
Copy link
Author

Oh so that is why I need to click it first before it take effect? No, its a plain html only.

@ixisio
Copy link
Owner

ixisio commented Aug 18, 2014

@thecodingwhale have a demo link for me?

@shica77
Copy link

shica77 commented Oct 28, 2014

The "First-Click-Problem" occurs only (in my case) if the carousel isn´t initialized via JavaScript but rather via Data-Attributes. If I initialize the carousel via js, everything works find. But thats not the solution, in my document i need the config via data-attributes (also the data-ride-Attr.) - and this is redundant...

@ixisio
Copy link
Owner

ixisio commented Oct 28, 2014

@shica77 I will carry on. Thanks for your findings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants