Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hide captions on smaller screens #2

Open
conoverm opened this issue Oct 16, 2013 · 5 comments
Open

Do not hide captions on smaller screens #2

conoverm opened this issue Oct 16, 2013 · 5 comments
Assignees
Milestone

Comments

@conoverm
Copy link

On the example page when viewed on an iPad 2, the content within each ".item" does not show.

(It does swipe, though.)

2013-10-16_17 19 15_p_ipad

@ghost ghost assigned ixisio Oct 18, 2013
@ixisio
Copy link
Owner

ixisio commented Oct 18, 2013

hey @conoverm, thanks for reporting!

I've conceal the whole captions for smaller screen, cause of the limited space on these devices.

// Hide/rearrange for smaller screens
@media screen and (max-width: 768px) {

  // Show and left align the captions
  .carousel-caption {
    display: none
  }
}

However, I could imagine to make this optional. So you can enable captions on smaller screen via data-attributes.
would that be an option for you?

Cheers

@ixisio
Copy link
Owner

ixisio commented Oct 20, 2013

I've correct the media-query to exclude iPad portrait orientation (max-width:767px).

Have in mind to make this optional.

Cheers

@ixisio
Copy link
Owner

ixisio commented Jan 20, 2014

I decided to not include this feature. It feels a bit over-engineered, IMO.

@jtremback
Copy link

IMO, feels a little over-engineered to hide the captions in the first place. I think the styling details should be left to the implementer.

@ixisio
Copy link
Owner

ixisio commented Feb 13, 2014

hey @jtremback,
Agreed! will put it into the next release..

@ixisio ixisio reopened this Feb 13, 2014
@ixisio ixisio added this to the v1.0 milestone Feb 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants