Fix the tap gesture #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 10, 2014 13:48
So we can bundle it easier. And install it into the vendor folder.
Let the devs to choose what they want :)
But block the Y axis while dragging, and lock the X axis to the carousel if the gesture starts from there.
|
Thanks Sir! |
|
This fork shouldn't be merge ? |
|
So what about this PR? |
|
Hi @ixisio have you ever got any chance to review this PR? It's very old right now...not even sure if it make sense or if we can just close it. Any feedback is really appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically there are also other commits that leads to this fix.
I hope you'll merge this, since I really like this plugin but I don't want to be "just another fork" of this :)
Kind Regards!
Fixes #12