Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links not working #12

Open
petewilcock opened this issue Jan 28, 2014 · 14 comments
Open

Links not working #12

petewilcock opened this issue Jan 28, 2014 · 14 comments
Labels

Comments

@petewilcock
Copy link

Nexus 4;

The links for carousel images do not work- tags enclosed in - tapping to activate the link does nothing.

@ixisio
Copy link
Owner

ixisio commented Jan 28, 2014

which links do you mean? Indicators?

@petewilcock
Copy link
Author

Sorry, the html was removed. In img tags that are enclosed in a links.

@ixisio
Copy link
Owner

ixisio commented Feb 24, 2014

hey @MonkeyMatrix
can you explain it in more detail please!

@ixisio ixisio added the bug label Feb 24, 2014
@olavk
Copy link

olavk commented Feb 25, 2014

Yes i had the same problem. Fixed it with:
$('body').hammer().on("tap", ".touch-carousel a", function(event) {
window.location=$(this).attr('href');
});
This requires Hammer.js jQuery plugin.

However, this is not ideal, because our solution required the links to open in modal windows, so the javascript has to modified on a case-by-case basis.

@ghost
Copy link

ghost commented Jun 3, 2014

I'm using Bootstrap Touch Carousel with AngularJS, and have some links and buttons in my slides.

From what I've experienced, the "drag/swipe"-events disable the "click/tap"-events on buttons/links. So I cannot click the links/buttons that're in my slides.

I could manually reattach event handlers with jQuery on (click/tap), which reenabled the functionality, but this is kind of a "hack".

My issue is that I'm using ngClick on my buttons to handle the clicks, and the ngClick callback never gets called. I said previously, I can manually attach to the click/tap-events using jQuery, and then call the callbacks manually / redirect the user (like @olavk )

@ixisio
Copy link
Owner

ixisio commented Jun 3, 2014

@larsdr @olavk what would you propose?

@ghost
Copy link

ghost commented Jun 3, 2014

@ixisio Not sure, but I would think that the "dragging" should be disabled on "native clickable elements", or not interfer with links/buttons.

@ixisio
Copy link
Owner

ixisio commented Jun 3, 2014

@larsdr yeah, thats exactly what we need. I will dig into the "How" soon as possible..

@ghost
Copy link

ghost commented Jun 3, 2014

hehe, I wish I could help you with that part, @ixisio !

@ixisio
Copy link
Owner

ixisio commented Jun 3, 2014

@larsdr would appreciate your assistance!
Is this just a nexus 4 issue? on iOS, buttons inside carousel working perfectly for me..!?

@ghost
Copy link

ghost commented Jun 3, 2014

I was testing on a Samsung Galaxy S5 and iPhone 5s running iOS 7 (latest version).

The ngClick-button worked on iOS, but only when clicking twice. The android device didnt work at all. From what I reckon, the regular link-button didnt work at all, on either device.

I'll try to set up a test project with as little code as possible, replicating the error, one of these days.

@ixisio
Copy link
Owner

ixisio commented Jun 3, 2014

sounds great, thank you!

@adamn676
Copy link

adamn676 commented Jul 9, 2014

Any solution to this problem yet?

@ixisio
Copy link
Owner

ixisio commented Jul 22, 2014

@larsdr any progress made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants