Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract classes for OfferSet and Offer #98

Open
Zarquan opened this issue Dec 1, 2024 · 0 comments
Open

Abstract classes for OfferSet and Offer #98

Zarquan opened this issue Dec 1, 2024 · 0 comments

Comments

@Zarquan
Copy link
Member

Zarquan commented Dec 1, 2024

Add Abstract classes for OfferSet and ExecutionSession that extend AbstractComponent, with derived classes for the initial versions.

AbstractOfferSet:
  type: object
  required:
    - type
  discriminator:
    propertyName: type
    mapping:
      'urn:ivoa-offerset-0.1': 'IvoaOfferSet01'
    allOf:
      - $ref: 'AbstractComponent'
      - type: object
        properties:
          ....
          ....

This adds a type uri to OfferSet and ExecutionSession, leaving us space to have different versions in future.

AbstractOfferSet:
  type: object
  required:
    - type
  discriminator:
    propertyName: type
    mapping:
      'urn:ivoa-offerset-0.1': 'IvoaOfferSet01'
      'urn:ivoa-offerset-0.2': 'IvoaOfferSet02'
    allOf:
      - $ref: 'AbstractComponent'
      - type: object
        properties:
          ....
          ....

Same for ExecutionSession.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant