Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

partitions.csv not being picked up. #116

Open
axos88 opened this issue Sep 16, 2022 · 5 comments · May be fixed by #117 or #118
Open

partitions.csv not being picked up. #116

axos88 opened this issue Sep 16, 2022 · 5 comments · May be fixed by #117 or #118

Comments

@axos88
Copy link

axos88 commented Sep 16, 2022

sdkconfig.defaults is missing:

CONFIG_PARTITION_TABLE_SINGLE_APP=
CONFIG_PARTITION_TABLE_CUSTOM=y

But even then the build is looking for the partitions.csv in the wrong place

@axos88
Copy link
Author

axos88 commented Sep 16, 2022

I needed to add the following as well:

CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="../../../../../../partitions.csv"

pyaillet added a commit to pyaillet/rust-esp32-std-demo that referenced this issue Sep 22, 2022
@pyaillet pyaillet linked a pull request Sep 22, 2022 that will close this issue
@pyaillet
Copy link
Contributor

espflash documentation here states that you can either pass this as a parameter to the command or add a configuration in Cargo.toml

@axos88
Copy link
Author

axos88 commented Sep 24, 2022

The problem is that the example project has this file in the root directory, but it's not actually used, which is misleading. Either it would need to be added to the README.md, or these config options need to be added, so a newcomer is not confused by their edits to the partition table file not being picked up.

@pyaillet
Copy link
Contributor

Yes, that's why I proposed a PR #117 adding the configuration to Cargo.toml :)

@axos88
Copy link
Author

axos88 commented Sep 25, 2022

Sorry, I did not see that!

axos88 added a commit to axos88/rust-esp32-std-demo that referenced this issue Sep 25, 2022
Fixes ivmarkov#116

Also bails with build failures if the image would not fit into the partitions defined by the csv file.
@axos88 axos88 linked a pull request Sep 25, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants