Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puzzle Template coordinates!! #45

Open
pv33 opened this issue Sep 17, 2024 · 1 comment
Open

Puzzle Template coordinates!! #45

pv33 opened this issue Sep 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@pv33
Copy link
Member

pv33 commented Sep 17, 2024

What is the difference between pcorner and rLoc??

It looks like rcoords has the coordinates in what??
Should be only relative to puzzle piece template size, not bigger image.
To put in bigger image requires shifting them.
But by what coordinate? pcorner or rLoc? Which should prevail?

Is pcorner the original instantiation? rLoc is the current one? does this permit backtracking to original detected piece location or to puzzle solution location? What is up?

check out todo comments in piece.py around line 105. Looks like I commented on this a while back. It definitely needs to be resolved and then consistency maintained.

@pv33 pv33 added the bug Something isn't working label Sep 17, 2024
@pv33 pv33 self-assigned this Sep 17, 2024
@pv33
Copy link
Member Author

pv33 commented Oct 5, 2024

There is no functional difference at this point as long as nothing changes with the puzzle.
Also the code has dropped passing of the centroid because it was confusing. There may need to be a centroid field too.

In the end though, the rLoc will be the current location and pcorner will be the original location when instantiated. All plotting will be done with rLoc and not with pcorner. When the piece is shifted, the change should be applied to rLoc and not to pcorner.

What will be needed is to percolate this to the data association part. What is it does not have access to rLoc but only to pcorner?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant