Update tabletop plane for matplotlib fallback #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmiyaguchi
commented
May 19, 2023
| The test file visualize the extracted tabletop plane point cloud in the camera frame, which is a necessary step for the height estimation. | ||
| You can skip that testing file and run `python -m camera.d435.testing.height` directly. | ||
|
|
||
| ## Ubuntu Python Environment Setup |
There was a problem hiding this comment.
Got rid of this section because it adds more complexity to the environment than is needed, and is mostly out of date.
| @@ -17,6 +17,6 @@ | |||
| "improcessor @ git+https://github.com/ivapylibs/improcessor.git", | |||
| ], | |||
| extras_require={ | |||
| "viz": ["mayavi", "wxpython"] | |||
There was a problem hiding this comment.
wxpython is not great actually, pyqt5 seems to be the superior choice. This is left up to the user to install though,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7.
This adds in a fallback to matplotlib in case mayavi fails for some reason (ui backend not installed, VTK error, etc). While matplotlib is slow, it should work on pretty much any machine. I hesitate on adding pptk back, mostly because it's has such specific requirements (python 3.7). I tested this on my ubuntu 20.04 wsl2 instance which comes with python 3.8.10, after intalling PyQt5 manually via pip.
We can test the matplotlib backend at anytime by forcing it.