Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing values in helm templates #141

Open
zetneteork opened this issue Jan 24, 2023 · 5 comments
Open

Missing values in helm templates #141

zetneteork opened this issue Jan 24, 2023 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@zetneteork
Copy link
Contributor

In the helm chart, two values are missing, as previously added in Minecraft bedrock.
https://github.com/itzg/docker-minecraft-bedrock-server/blob/ab51be217cf5f245fcb3239466f145af3a9422ba/property-definitions.json#L112

https://github.com/itzg/docker-minecraft-bedrock-server/blob/ab51be217cf5f245fcb3239466f145af3a9422ba/property-definitions.json#L116

I did not find those two values can be easily controlled in the helm chart values.

  "emit-server-telemetry": {
    "env": "EMIT_SERVER_TELEMETRY",
    "allowed": ["true","false"]
  },
  "enable-lan-visibility": {
    "env": "ENABLE_LAN_VISIBILITY",
    "allowed": ["true","false"]
  }

I expect this feature can be added.

@itzg
Copy link
Owner

itzg commented Jan 24, 2023

You can use extraEnv to configure those.

I would accept a PR to associate specific values if you or anyone else is interested.

@itzg itzg added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 24, 2023
zetneteork added a commit to zetneteork/minecraft-server-charts that referenced this issue Jan 24, 2023
@zetneteork
Copy link
Contributor Author

#142

@zetneteork
Copy link
Contributor Author

You can use extraEnv to configure those.

I would accept a PR to associate specific values if you or anyone else is interested.

It would be useful to list available options suitable for bedrock extraEnv in README file.

@itzg
Copy link
Owner

itzg commented Jan 24, 2023

Interesting idea. A link to the properties mapping file would be a nice compromise. Want to include that with your PR?

itzg pushed a commit that referenced this issue Jan 28, 2023
@nilsrenes
Copy link

Hi , do you have a link for adding custom env options via helm kubernetes ? Do I just add them to the Charts.yml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants