Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development Branch #42

Open
adrianwells opened this issue Oct 9, 2018 · 6 comments
Open

Development Branch #42

adrianwells opened this issue Oct 9, 2018 · 6 comments

Comments

@adrianwells
Copy link
Collaborator

@CalebAlbers - Hello. May you please update the development branch to match master to help keep it in sync with master if not ahead of it depending on the work being performed?

@ecspresso
Copy link
Contributor

The development branch is still behind and is not used. Do we have any plans for this branch?

@oOblik
Copy link
Contributor

oOblik commented Sep 22, 2023

I'd recommend updating the development branch and adding a CONTRIBUTING.md to instruct that all PRs be made on the development branch. It would take some of the stress away from merging directly into master, and would help to streamline a test/release process in the future.

@adrianwells
Copy link
Collaborator Author

@oOblik this seems like a reasonable approach. FYI @davidhaymond

@davidhaymond
Copy link
Collaborator

I definitely agree that we should add CONTRIBUTING.md. However, I am personally of the opinion that development for projects with versioned releases should take place on the default branch—in this case, master. This is not a continuous deployment scenario where master is automatically deployed to production. Stable versions should be tagged and released using GitHub releases and the PowerShell Gallery; there is no need to pin master to the latest stable release. I think it adds unneeded overhead (resolving conflicts on a development branch will be no different than resolving them on a master branch).

Of course, care should be taken to keep the master branch clean; only polished, tested PRs should be merged, and incomplete features should be finished (perhaps in a separate feature branch for larger features) before merging into master. That way, master can be a sort of "bleeding-edge" build or rolling beta that contains the latest work. Many, many projects use master for development, including PowerShell itself. Other large projects using the default branch for development include Vue, React, Linux, Go, and Django. Development branches seem more common in web apps that are continuously deployed from master.

I would love to hear the thoughts of contributors on this matter. Whatever the community decides on is fine with me.

@adrianwells
Copy link
Collaborator Author

@davidhaymond, Good points and examples. With the current cadence, removing the development branch seems simpler to maintain. Will plan to remove the development branch. Sounds like drafting a CONTRIBUTING.md is worthwhile.

@davidhaymond
Copy link
Collaborator

Thanks, @adrianwells. I can work on drafting CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants