Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate managed-by labels #195

Merged
merged 9 commits into from
Sep 17, 2023
Merged

Remove duplicate managed-by labels #195

merged 9 commits into from
Sep 17, 2023

Conversation

0x2b3bfa0
Copy link
Member

app.kubernetes.io/managed-by: {{ .Release.Service }}

@0x2b3bfa0 0x2b3bfa0 added the bug Something isn't working label Sep 17, 2023
@0x2b3bfa0 0x2b3bfa0 self-assigned this Sep 17, 2023
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review September 17, 2023 02:07
@0x2b3bfa0 0x2b3bfa0 requested a review from a team September 17, 2023 02:07
@0x2b3bfa0 0x2b3bfa0 merged commit eaf565c into main Sep 17, 2023
4 checks passed
@0x2b3bfa0 0x2b3bfa0 deleted the 0x2b3bfa0-patch-1 branch September 17, 2023 02:16
@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Sep 17, 2023

@iterative/platform, merging this one because it fixes a critical bug; I have moved the other change, subject to human considerations, to a separate pull request.

@jesper7
Copy link
Contributor

jesper7 commented Sep 18, 2023

Thank you!

@0x2b3bfa0
Copy link
Member Author

For the record, this was the error message, when running make skaffold-dev

Error: INSTALLATION FAILED: error while running post render on files: error while running command /usr/local/bin/skaffold. error output:
reading Kubernetes YAML: yaml: unmarshal errors:
  line 12: mapping key "app.kubernetes.io/managed-by" already defined at line 11
exit status 1

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Sep 18, 2023

https://pkg.go.dev/github.com/GoogleContainerTools/skaffold/[email protected]/pkg/skaffold/yaml#UnmarshalStrict

UnmarshalStrict is like Unmarshal except that any fields that are found in the data that do not have corresponding struct members, or mapping keys that are duplicates, will result in an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants