-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm-docs): Run helm-docs as part of the release automation #147
Conversation
@0x2b3bfa0 maybe we could commit this to the PR 🤔 helm-charts/.github/workflows/test.yaml Lines 76 to 80 in 9d518dd
|
@0x2b3bfa0 in #148 I created a workflow for automated helm-docs update PTAL :-) |
- name: Generate token | ||
id: generate_token | ||
uses: tibdex/github-app-token@b62528385c34dbc9f38e5f4225ac829252d1ea92 | ||
with: | ||
app_id: ${{ secrets.PROJECT_ACTIONS_MANAGEMENT_APP_ID }} | ||
private_key: ${{ secrets.PROJECT_ACTIONS_MANAGEMENT_APP_PEM }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I right now used the GitHub App, but will propose some naming conventions for apps per repo or role 🤔
5813e01
to
076ca57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a minor comment
Fixes e.g. #146