Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

studio: Don't try to send data events if DVC start event failed. #607

Open
daavoo opened this issue Jun 26, 2023 · 3 comments
Open

studio: Don't try to send data events if DVC start event failed. #607

daavoo opened this issue Jun 26, 2023 · 3 comments
Labels
A: dvc DVC integration A: studio Area: Studio integration enhancement p3-nice-to-have

Comments

@daavoo
Copy link
Contributor

daavoo commented Jun 26, 2023

When using DVCLive inside a stage being executed by dvc exp run, we still try to send data events on every step even if the start event sent by DVC failed due to misconfiguration.

From DVC side, we need to expose that the start event failed.

@daavoo daavoo added enhancement A: dvc DVC integration A: studio Area: Studio integration labels Jun 26, 2023
@dberenbaum dberenbaum added the p1-important Include in the next sprint label Jun 26, 2023
@dberenbaum dberenbaum added this to DVC Jun 26, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DVC Jun 26, 2023
@daavoo daavoo removed the p1-important Include in the next sprint label Sep 5, 2023
@daavoo
Copy link
Contributor Author

daavoo commented Sep 5, 2023

I am no longer sure if we want to not try to send data event, at least in the current state of the client where we are not really differentiating the failure.

In some cases, start might have failed for some server error or timeout, etc, and we would actually want to try sending the data again.

Dropping p1 for now, we need to handle repeating failures in #685 so worst case scenario (i.e. auth failure) we would be sending one or a few requests that will be rejected.

@dberenbaum
Copy link
Collaborator

@daavoo Do you want to keep it in the backlog or should we drop it?

@daavoo daavoo removed this from DVC Sep 6, 2023
@daavoo
Copy link
Contributor Author

daavoo commented Sep 6, 2023

@daavoo Do you want to keep it in the backlog or should we drop it?

I dropped it. Ideally, we should identify certain failures during start in DVC (i.e. unauthorized) where we know there is no point in trying to send data again.

@daavoo daavoo removed their assignment Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: dvc DVC integration A: studio Area: Studio integration enhancement p3-nice-to-have
Projects
None yet
Development

No branches or pull requests

2 participants