-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Humidity sensor on thermostat exposed as separate service #869
Comments
Main tricky part is that two separate converters need to be aware of each others behavior, so they (unfortunately) need to be coupled somehow. Functionally though, you still have all the data available in HomeKit, right? |
That's already adding coupling in my opinion, but it's implicit (which might even be harder to maintain in the long run). I think one of the things I never considered, is that for devices that do have multiple service handlers, we should somehow say what it's main purpose is. Probably that may also solve the UX issue you are mentioning (as it's mostly correct if you exclude it first). |
We should definitely make it configurable, in case auto-detection isn’t possible.
Yup, the humidity service is unfortunately first in line… 😅 |
Is there an existing issue for this?
Describe the bug
When a thermostat also exposes a humidity sensor on the same endpoint, the humidity sensor currently gets configured as a secondary service, and not as the optional
CurrentRelativeHumidity
characteristic for said thermostat service.It's (for some reason?) not possible to ungroup these two services, meaning the accessory tile in Home will only show a sensor icon and not the current state of the thermostat.
A possible solution might be to simply skip service creation for humidity sensors in case
climate
is also exposed on the same endpoint. Adding the optional characteristic should also be rather trivial, because we probably can reuse proven code from #854. 😉Related devices
No response
Related Devices
Steps To Reproduce
No response
Expected behavior
A thermostat service with the optional
CurrentRelativeHumidity
characteristic gets exposed to HomeKit, and no additional humidity service is created.Device entry
Status update
No response
Messages from this plugin
No response
This plugin
1.11.0-beta.5
Homebridge
1.7.0
Zigbee2MQTT
1.37.1-dev
Homebridge Config UI X (if applicable)
No response
The text was updated successfully, but these errors were encountered: