-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1156 downsampling experiment #1165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a few style nits. (And maybe one other small thing? Apparently I left 8 comments but I only found 7 looking back. 🤷♂️)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick. Otherwise, looks good and just needs history cleanup. Thank you.
Note that the confidence score is not set on a per-decode basis here since we currently do not alter confidence values with GNN decodes in ADAM.
558ae62
to
2d84db2
Compare
Closes #1156 and #1157
Performed both within the same branch because I needed similar scripts for both for visualizing GNN/ADAM performance between different experiments.
There are 4 important features added here:
k
GNN decodes per object fromshape_stroke_graph_inference.py
k
decodes as a node in ADAM and handle accordingly.Aside from those, most of the new additions here are just adding parameter files which I used the preexisting downsample/unknown object generation scripts to create the curricula for.