Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1156 downsampling experiment #1165

Merged
merged 8 commits into from
Aug 18, 2022
Merged

1156 downsampling experiment #1165

merged 8 commits into from
Aug 18, 2022

Conversation

sidharth-sundar
Copy link
Collaborator

Closes #1156 and #1157

Performed both within the same branch because I needed similar scripts for both for visualizing GNN/ADAM performance between different experiments.

There are 4 important features added here:

  1. Script to generate confusion matrix for GNN outputs given an input curriculum
  2. Script to generate confusion matrix for ADAM outputs given an input curriculum
  3. Script to generate confusion matrix for top GNN outputs per object given an input curriculum
  4. Added functionality to
    • Retrieve top k GNN decodes per object from shape_stroke_graph_inference.py
    • Add each of the top k decodes as a node in ADAM and handle accordingly.

Aside from those, most of the new additions here are just adding parameter files which I used the preexisting downsample/unknown object generation scripts to create the curricula for.

@sidharth-sundar sidharth-sundar self-assigned this Aug 16, 2022
@sidharth-sundar sidharth-sundar linked an issue Aug 16, 2022 that may be closed by this pull request
Copy link
Collaborator

@spigo900 spigo900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few style nits. (And maybe one other small thing? Apparently I left 8 comments but I only found 7 looking back. 🤷‍♂️)

adam_preprocessing/shape_stroke_graph_inference.py Outdated Show resolved Hide resolved
adam_preprocessing/shape_stroke_graph_inference.py Outdated Show resolved Hide resolved
scripts/GNN_vs_expected.py Outdated Show resolved Hide resolved
scripts/GNN_vs_expected.py Outdated Show resolved Hide resolved
scripts/adam_decode_vs_expected.py Outdated Show resolved Hide resolved
scripts/GNN_topk_analysis.py Outdated Show resolved Hide resolved
scripts/GNN_topk_analysis.py Outdated Show resolved Hide resolved
scripts/adam_decode_vs_expected.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@spigo900 spigo900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick. Otherwise, looks good and just needs history cleanup. Thank you.

scripts/GNN_topk_analysis.py Outdated Show resolved Hide resolved
@sidharth-sundar sidharth-sundar force-pushed the 1156-downsampling-experiment branch from 558ae62 to 2d84db2 Compare August 18, 2022 19:20
@spigo900 spigo900 merged commit a7fed4a into master Aug 18, 2022
@spigo900 spigo900 deleted the 1156-downsampling-experiment branch August 18, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downsampling experiment
2 participants