Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining the PS-selection with SHP-finding and phase-linking #24

Open
scottstanie opened this issue Feb 1, 2023 · 0 comments
Open
Labels
enhancement New feature or request run time Related to workflow processing speed

Comments

@scottstanie
Copy link
Collaborator

scottstanie commented Feb 1, 2023

Currently PS selection happens in a separate step. This means we load the data stack once, save/update the PS, then reload all blocks to phase link.

Should we do the PS selection + SHP finding + phase link all in same loading period?

The timings in #6 show that when we calculate PS on a whole stack, the loading time is the majority of the time and we'd get a large improvement by only loading stack blocks once.

But, it won't be as a big a speedup for online-updating of the PS, where we'd only pull and iterate over 1-2 SLCs to get a new PS map. Thus this is low priority.

@scottstanie scottstanie added the enhancement New feature or request label Feb 1, 2023
@scottstanie scottstanie added the run time Related to workflow processing speed label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request run time Related to workflow processing speed
Projects
None yet
Development

No branches or pull requests

1 participant