Skip to content

Commit

Permalink
[#3208] reordered includes
Browse files Browse the repository at this point in the history
  • Loading branch information
Razvan Becheriu committed Mar 11, 2024
1 parent eea21ad commit d5d2856
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 41 deletions.
3 changes: 2 additions & 1 deletion src/lib/dns/message.h
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ class SectionIterator {
using pointer = T*;
using reference = T&;

SectionIterator() : impl_(0) {}
SectionIterator() : impl_(0) {
}
SectionIterator(const SectionIteratorImpl<T>& impl);
~SectionIterator();
SectionIterator(const SectionIterator<T>& source);
Expand Down
4 changes: 0 additions & 4 deletions src/lib/dns/messagerenderer.h
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,3 @@ class MessageRenderer : public AbstractMessageRenderer,
}
}
#endif // MESSAGERENDERER_H

// Local Variables:
// mode: c++
// End:
4 changes: 0 additions & 4 deletions src/lib/dns/name_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,3 @@ extern const uint8_t maptolower[];
} // end of dns
} // end of isc
#endif // NAME_INTERNAL_H

// Local Variables:
// mode: c++
// End:
6 changes: 3 additions & 3 deletions src/lib/dns/rdataclass.cc
Original file line number Diff line number Diff line change
Expand Up @@ -578,8 +578,7 @@ A::A(const std::string&) {
}

A::A(MasterLexer&, const Name*,
MasterLoader::Options, MasterLoaderCallbacks&)
{
MasterLoader::Options, MasterLoaderCallbacks&) {
// TBD
}

Expand Down Expand Up @@ -609,7 +608,8 @@ A::toText() const {

int
A::compare(const Rdata&) const {
return (0); // dummy. TBD
// TBD
return (0);
}

} // end of namespace "ch"
Expand Down
8 changes: 3 additions & 5 deletions src/lib/dns/tests/rdata_in_a_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,20 @@
#include <config.h>

#include <dns/rdataclass.h>

#include <util/buffer.h>
#include <dns/exceptions.h>
#include <dns/messagerenderer.h>
#include <dns/master_lexer.h>
#include <dns/master_loader.h>
#include <dns/rdata.h>
#include <dns/rrclass.h>
#include <dns/rrtype.h>

#include <gtest/gtest.h>

#include <dns/tests/unittest_util.h>
#include <dns/tests/rdata_unittest.h>
#include <util/buffer.h>
#include <util/unittests/wiredata.h>

#include <gtest/gtest.h>

#include <sstream>

#include <arpa/inet.h>
Expand Down
7 changes: 3 additions & 4 deletions src/lib/dns/tests/rdata_in_aaaa_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,19 @@

#include <config.h>

#include <util/buffer.h>
#include <dns/exceptions.h>
#include <dns/messagerenderer.h>
#include <dns/rdata.h>
#include <dns/rdataclass.h>
#include <dns/rrclass.h>
#include <dns/rrtype.h>

#include <gtest/gtest.h>

#include <dns/tests/unittest_util.h>
#include <dns/tests/rdata_unittest.h>
#include <util/buffer.h>
#include <util/unittests/wiredata.h>

#include <gtest/gtest.h>

using namespace std;
using namespace isc::dns;
using namespace isc::util;
Expand Down
29 changes: 13 additions & 16 deletions src/lib/dns/tests/tsig_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,7 @@

#include <config.h>

#include <time.h>
#include <string>
#include <stdexcept>
#include <vector>

#include <boost/scoped_ptr.hpp>

#include <gtest/gtest.h>

#include <exceptions/exceptions.h>

#include <util/buffer.h>
#include <util/encode/encode.h>
#include <util/unittests/newhook.h>
#include <util/time_utilities.h>

#include <dns/message.h>
#include <dns/messagerenderer.h>
#include <dns/question.h>
Expand All @@ -32,10 +17,22 @@
#include <dns/tsig.h>
#include <dns/tsigkey.h>
#include <dns/tsigrecord.h>

#include <dns/tests/unittest_util.h>
#include <util/buffer.h>
#include <util/encode/encode.h>
#include <util/unittests/newhook.h>
#include <util/time_utilities.h>
#include <util/unittests/wiredata.h>

#include <time.h>
#include <string>
#include <stdexcept>
#include <vector>

#include <boost/scoped_ptr.hpp>

#include <gtest/gtest.h>

using namespace std;
using namespace isc;
using namespace isc::dns;
Expand Down
4 changes: 0 additions & 4 deletions src/lib/dns/txt_like.h
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,3 @@ template<class Type, uint16_t typeCode>class TXTLikeImpl {
} // namespace isc

#endif // TXT_LIKE_H

// Local Variables:
// mode: c++
// End:

0 comments on commit d5d2856

Please sign in to comment.