Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with Electron v10.x.y+ when dealing with .asar #223

Open
htxuuu opened this issue Dec 14, 2021 · 2 comments · Fixed by electron/electron#34764 · May be fixed by #232
Open

Incompatible with Electron v10.x.y+ when dealing with .asar #223

htxuuu opened this issue Dec 14, 2021 · 2 comments · Fixed by electron/electron#34764 · May be fixed by #232

Comments

@htxuuu
Copy link

htxuuu commented Dec 14, 2021 •
edited
Loading

when Electron dealing with directory with .asar, will directly access options.withFileType.
See: https://github.com/electron/electron/blob/4594af595eab12e76034d0d0e94539ef390024bb/lib/common/asar.js#L597

and in graceful-fs v4.2.7 and above, will set options to null in some circumstances.
For example:

node-graceful-fs/graceful-fs.js

Line 113 in 9ec3413

cb = options, options = null

when options sets to null, options.withFileTypes in Electron will cause error.

I suppose it is a bug.
@htxuuu
Copy link
Author

htxuuu commented Dec 14, 2021

currently I use yarn and set:

"resolutions": {
    "graceful-fs": "4.2.6"
 }

in package.json to lock graceful-fs in v4.2.6

@jarrodek
Copy link

jarrodek commented Feb 7, 2022

I have a similar issue. The options = null should be replaced with options = undefined because null cannot be replaced with default parameters.
Because of that, I am having trouble running my electron application. I see errors with this module.

dsanders11 added a commit to dsanders11/node-graceful-fs that referenced this issue Jun 26, 2022
@dsanders11
fix: use undefined instead of null for readdir options
5a71819 
Fixes isaacs#223
This was referenced Jun 26, 2022
Open
Merged
dsanders11 added a commit to dsanders11/node-graceful-fs that referenced this issue Jun 27, 2022
@dsanders11
fix: use undefined instead of null for options
208a223 
Fixes isaacs#223
@dsanders11 dsanders11 mentioned this issue Jun 27, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jarrodek @htxuuu