-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Ray Workflow: Multiple Run Support, Distributed Hyperparameter Tuning, and Consistent Setup Across Local/Cloud #1301
Open
glvov-bdai
wants to merge
132
commits into
isaac-sim:main
Choose a base branch
from
glvov-bdai:feature/hyperparam_tune
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,455
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ai/IsaacLab into feature/hyperparam_tune
Signed-off-by: garylvov <[email protected]>
…ai/IsaacLab into feature/hyperparam_tune
I also made this walk-through video for this integration. I'd be happy to link it in the ray.rst lmk what you think |
jsmith-bdai
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did another pass through, still need to try it out
source/standalone/workflows/ray/hyperparameter_tuning/vision_cartpole_cfg.py
Show resolved
Hide resolved
Co-authored-by: James Smith <[email protected]> Signed-off-by: garylvov <[email protected]>
Co-authored-by: James Smith <[email protected]> Signed-off-by: garylvov <[email protected]>
Co-authored-by: James Smith <[email protected]> Signed-off-by: garylvov <[email protected]>
Co-authored-by: James Smith <[email protected]> Signed-off-by: garylvov <[email protected]>
Co-authored-by: James Smith <[email protected]> Signed-off-by: garylvov <[email protected]>
Co-authored-by: James Smith <[email protected]> Signed-off-by: garylvov <[email protected]>
Co-authored-by: James Smith <[email protected]> Signed-off-by: garylvov <[email protected]>
Signed-off-by: glvov-bdai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Ray support, which enables a lot of really cool stuff by leveraging the existing Hydra support, including but not limited to:
I know this PR seems huge, but most of the code diff is config files / argparser stuff / documentation / comments
My main project at BDAI is changing from RL to LfD effective November 1st, so I'm posting this PR as early as possible so I have as much time as possible to address comments.
It would be much appreciated if the NVIDIA folks can work with me to get this reviewed ASAP. I realize that this is a pretty big PR; but I also think that it adds a lot of cool functionality, and the merging process will go much smoother if I am able to devote time to this while at work. Thanks! ;)
Fixes # (issue#1190), (issue#1213)
Type of change
Screenshots
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there