Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Assigned as Admin if OKTA ADMIN_GROUPS are Configured and User has OKTA Groups #4

Open
mm-dennismccann opened this issue Mar 5, 2024 · 1 comment

Comments

@mm-dennismccann
Copy link

I was looking into why every account seemed to first log into the host app was automatically designated as a superuser.

In the code below, it looks like any user is made a superuser if they have existing OKTA groups and the hosting app has a value for ADMIN_GROUPS in the OKTA configuration.

I think the intended condition is if any of the OKTA ADMIN_GROUPS are inside the set of user OKTA groups.

if frozenset(settings.OKTA_CLIENT['ADMIN_GROUPS']) & frozenset(user_groups):
LOGGER.debug('Found an admin: %s', login)

@irvingleonard
Copy link
Owner

The intended logic is to do set(A,B) & set(B,C) which should yield set(B) (set intersection).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants