From cf0aafddbc01be6f60bbc0e408f28e545cb04f6d Mon Sep 17 00:00:00 2001 From: AndyKIron Date: Sun, 13 Oct 2024 15:04:09 +0300 Subject: [PATCH 1/2] chore(isct-428): added prop inputErrorIconShow to the table-column entity inputErrorIconShow (default - false) user to show input-inline error as icon in table component v1 --- .github/actions/deploy-storybook.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/actions/deploy-storybook.sh b/.github/actions/deploy-storybook.sh index 89422733f..87347ef8e 100755 --- a/.github/actions/deploy-storybook.sh +++ b/.github/actions/deploy-storybook.sh @@ -2,6 +2,7 @@ set -e #branch=$1 + #folder=$(echo "$branch" | tr / -) folder=$1 From ecb86975d16a807ec92b246fea5437a30019acb9 Mon Sep 17 00:00:00 2001 From: AndyKIron Date: Sun, 13 Oct 2024 16:13:30 +0300 Subject: [PATCH 2/2] ci(storybook): remove storybook deploy related code - it moved to the fusion-actions --- .github/actions/deploy-storybook.sh | 14 ----- .github/workflows/deploy-storybook.yml | 85 -------------------------- package.json | 7 +-- 3 files changed, 1 insertion(+), 105 deletions(-) delete mode 100755 .github/actions/deploy-storybook.sh delete mode 100644 .github/workflows/deploy-storybook.yml diff --git a/.github/actions/deploy-storybook.sh b/.github/actions/deploy-storybook.sh deleted file mode 100755 index 87347ef8e..000000000 --- a/.github/actions/deploy-storybook.sh +++ /dev/null @@ -1,14 +0,0 @@ -#!/bin/bash -set -e - -#branch=$1 - -#folder=$(echo "$branch" | tr / -) - -folder=$1 - -FOLDER=$folder npm run aws:deploy-storybook - -FOLDER=$folder npm run cf:invalidate - -exit $lastCode diff --git a/.github/workflows/deploy-storybook.yml b/.github/workflows/deploy-storybook.yml deleted file mode 100644 index ecf415d49..000000000 --- a/.github/workflows/deploy-storybook.yml +++ /dev/null @@ -1,85 +0,0 @@ -name: Storybook Deploy - -on: - workflow_dispatch: - -permissions: - id-token: write - contents: read - -jobs: - Deploy: - runs-on: ubuntu-latest - outputs: - branch_name: ${{ steps.branch_name.outputs.branch }} - folder_name: ${{ steps.branch_name.outputs.folder }} - steps: - - uses: actions/checkout@v3 - - name: Setup Node.js Enviroment 🛠️ - uses: actions/setup-node@v3 - with: - node-version: '20' - cache: 'npm' - - - name: Install system dependencies - run: | - sudo apt-get update - sudo apt-get install -y vim jq - - - name: Cache node deps - id: cache-deps - uses: actions/cache@v3 - with: - path: ./node_modules - key: ${{ runner.os }}-build-${{ hashFiles('**/package-lock.json') }} - - - name: Install Dependencies 📦 - if: steps.cache-deps.outputs.cache-hit != 'true' - run: npm ci - - - name: Extract branch name - shell: bash - run: | - echo "branch=$(echo ${GITHUB_REF#refs/heads/})" >> $GITHUB_OUTPUT - echo "folder=$(echo ${GITHUB_REF#refs/heads/} | tr / -)" >> $GITHUB_OUTPUT - id: branch_name - - - - name: Test Output - run: | - echo "Folder: ${{ steps.branch_name.outputs.folder }}" - - - name: Build storybook static - run: npm run build-storybook - - - name: Install AWS cli - run: | - if ! [ -x "$(command -v aws)" ]; then - curl "https://awscli.amazonaws.com/awscli-exe-linux-x86_64-2.0.30.zip" -o "awscliv2.zip" - unzip awscliv2.zip - sudo ./aws/install - fi - - - name: Configure AWS credentials - uses: aws-actions/configure-aws-credentials@v2 - with: - aws-region: us-east-1 - role-to-assume: arn:aws:iam::032106861074:role/github-runners-demand-team-role - - - name: Deploy to s3 bucket - run: '${GITHUB_WORKSPACE}/.github/actions/deploy-storybook.sh ${{ steps.branch_name.outputs.folder }} ' - - notify-success: - needs: Deploy - if: ${{ always() && needs.Deploy.result == 'success'}} - runs-on: ubuntu-latest - steps: - - - name: 'Deploy success notify' - uses: ironSource/action-slack-notification@v1 - with: - channel: fusion-docs-notifications - username: FusionUI-CI - icon_url: "https://avatars.githubusercontent.com/t/5433436?s=32&v=4" - message: " Storybook on branch *${{ needs.Deploy.outputs.branch_name }}* by *${{github.actor}}* published success.\n You can check it on: https://fusion-storybook.ironsrc.mobi/branch_${{ needs.Deploy.outputs.folder_name }}/" - slack_webhook: ${{ secrets.SLACK_PATH }} diff --git a/package.json b/package.json index 2bb303105..50b5f7deb 100644 --- a/package.json +++ b/package.json @@ -31,12 +31,7 @@ "release": "commit-and-tag-version", "docs:show": "compodoc -p ./tsconfig.doc.json -s --disablePrivate --disableProtected --disableLifeCycleHooks --disableInternal", "storybook": "ng run fusion-ui:storybook", - "build-storybook": "ng run fusion-ui:build-storybook", - "aws:build-storybook": "npm run build-storybook", - "aws:deploy-storybook": "npm run deploy:static-storybook && npm run deploy:html-storybook", - "deploy:static-storybook": "aws s3 cp ./storybook-static s3://fusion-storybook/$FOLDER --recursive --exclude 'index.html'", - "deploy:html-storybook": "aws s3 cp ./storybook-static/index.html s3://fusion-storybook/$FOLDER/index.html --cache-control='max-age=0, s-maxage=604800'", - "cf:invalidate": "aws cloudfront create-invalidation --distribution-id E3LE7X89G2T5J3 --paths \"/$FOLDER/*\" " + "build-storybook": "ng run fusion-ui:build-storybook" }, "lint-staged": { "**/*{.ts,.json}": "prettier --config ./prettier.config.js --write"