Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp UI #26

Merged
merged 24 commits into from
Aug 25, 2023
Merged

Revamp UI #26

merged 24 commits into from
Aug 25, 2023

Conversation

Franpastoragusti
Copy link
Collaborator

@Franpastoragusti Franpastoragusti commented Aug 24, 2023

New UX concept implemented

@Franpastoragusti Franpastoragusti self-assigned this Aug 24, 2023
This was linked to issues Aug 24, 2023
Copy link
Owner

@irfanbozkurt irfanbozkurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing contribution with the code structure + amazing design. I'm approving because I'll be sending a follow-up PR on following issues:

  • This project implements a clear FSM and moving forward is made very easy with this PR, but moving backwards was very problematic.
    • From asset selection to hacked address selection is not possible
    • From bundling phase to asset selection phase is possible, however; when the user removes 'unsignedTx' in the bundling phase and goes back to asset selection, the old selection appears back.
  • Adding a custom call adds the call to the "assets" but doesn't "select" the call as an "asset". As a result, user needs to both add the custom call and then select it.
  • No check on when hacked account and safe account are the same
  • Most importantly, I strongly disagree that disabling "useLocalStorage" for all state variables is a good idea. Especially for "auto-detected assets". We make hundreds of API calls to re-fetch the same information again and again.
  • Minor renamings
  • Further deconstruction

@irfanbozkurt irfanbozkurt merged commit 19b1e4f into irfanbozkurt:develop Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants