generated from scaffold-eth/scaffold-eth-2
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp UI #26
Merged
irfanbozkurt
merged 24 commits into
irfanbozkurt:develop
from
Franpastoragusti:revamp-ui
Aug 25, 2023
Merged
Revamp UI #26
irfanbozkurt
merged 24 commits into
irfanbozkurt:develop
from
Franpastoragusti:revamp-ui
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 24, 2023
irfanbozkurt
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing contribution with the code structure + amazing design. I'm approving because I'll be sending a follow-up PR on following issues:
- This project implements a clear FSM and moving forward is made very easy with this PR, but moving backwards was very problematic.
- From asset selection to hacked address selection is not possible
- From bundling phase to asset selection phase is possible, however; when the user removes 'unsignedTx' in the bundling phase and goes back to asset selection, the old selection appears back.
- Adding a custom call adds the call to the "assets" but doesn't "select" the call as an "asset". As a result, user needs to both add the custom call and then select it.
- No check on when hacked account and safe account are the same
- Most importantly, I strongly disagree that disabling "useLocalStorage" for all state variables is a good idea. Especially for "auto-detected assets". We make hundreds of API calls to re-fetch the same information again and again.
- Minor renamings
- Further deconstruction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New UX concept implemented