From ec8ea540d77fafbaecfbd672b9600779d2cafba2 Mon Sep 17 00:00:00 2001 From: Adin Schmahmann Date: Mon, 20 Mar 2023 13:40:06 -0400 Subject: [PATCH] feat(ipip): added routing v1 routers parameter IPIP --- IPIP/0388-routing-v1-multiple-routers.md | 61 ++++++++++++++++++++++++ routing/ROUTING_V1_HTTP.md | 20 +++++++- 2 files changed, 80 insertions(+), 1 deletion(-) create mode 100644 IPIP/0388-routing-v1-multiple-routers.md diff --git a/IPIP/0388-routing-v1-multiple-routers.md b/IPIP/0388-routing-v1-multiple-routers.md new file mode 100644 index 000000000..6a1db46cc --- /dev/null +++ b/IPIP/0388-routing-v1-multiple-routers.md @@ -0,0 +1,61 @@ +# IPIP-0388: Routing v1 Multiple Routers + + + +- Start Date: 2023-03-20 +- Related Issues: + - (add links here) + +## Summary + +Adding support for querying individual routers to a single Routing v1 HTTP endpoint. + +## Motivation + +At the moment there is no way for a Routing v1 client to ask for a specific routing backend to be used nor for a Routing v1 endpoint to signal what routing backends they support. When Routing v1 is used as a proxy for one or more routing systems (e.g. IPFS Public DHT, IPNI, mainlineDHT, ...) clients may want to be able to judge a given endpoint's suitability to be a proxy for that routing system. + +For instance if all-the-routers.alice.tld is very good at proxying IPNI requests but bad at proxying IPFS Public DHT requests, but dht-proxy.bob.tld is good at proxying IPFS Public DHT requests. In this scenario clients wanting good responses would have to ask both Alice and Bob to do DHT lookups for them even though Alice's DHT lookups are unneccessary because Bob is doing them. Similarly, clients could evaluate the best endpoint to request responses from since they can now do comparisons between largely equivalent routing systems. Additionally, this allows clients to discover the data sources behind Routing v1 endpoints without as much out of band information. + +## Detailed design + +AKA Solution Proposal + +The proposal is to: +1. Add a `?routing=` optional parameter to `GET /routing/v1/providers/{CID}` that indicates which routing systems to use +2. Add an `OPTIONS /routing/v1/providers` endpoint which when queried may respond with a `SUPPORTED_ROUTERS` header key, with the value as the comma separated list of the routing systems supported + +## Design rationale + +The rationale fleshes out the specification by describing what motivated +the design and why particular design decisions were made. + +Provide evidence of rough consensus and working code within the community, +and discuss important objections or concerns raised during discussion. + +### User benefit + +End users will be able to query endpoints that provide proxies for multiple routing systems (e.g. cid.contact/routing/v1) and get back DHT, IPNI or both depending on what they need. + +For users that are running a DHT client locally they can dynamically evaluate if cid.contact's DHT proxy is either good enough that they can conserve their local resources by reducing how they use their client. Similarly, if they discover that their local DHT results are better than cid.contact's DHT proxy then they can ease the burden on cid.contact by only requesting IPNI results and doing the DHT lookups themselves. + +### Compatibility + +This should not effect existing clients or servers + +### Security + +Mostly not applicable. However, clients should not expect proxies to give 1:1 mappings with the underlying systems if they are too expensive and should consider that when evaluating the performance of individual endpoints. + +### Alternatives + +- Having clients fetch from multiple sources which may have overlapping data -> lots of work on servers and extra processing work for clients +- Having clients fetch from a single source with the best data -> is not friendly to the introduction of new services and may result in less data being retrieved +- Having servers restrict to one endpoint per router (e.g. dht.alice.tld and ipni.alice.tld or alice.tld/dht/routing/v1 and alice.tld/ipni/routing/v1) -> also doable, but discoverability of new router types would require other semantics (e.g. an OPTIONS request to alice.tld/routing/v1) +- Having `OPTIONS` on `/routing/v1` instead of `/routing/v1/providers` -> also good, perhaps a better choice. given that not every router will support every request type there's a tradeoff around how low level you put the `OPTIONS`. In theory both could be supported. +- Having `OPTIONS` on `/routing/v1/providers/{CID}` in the event the CID tells you some information about which providers to use (e.g. for non-BitTorrent codecs don't use mainline DHT) -> also doable. Unclear if this would be useful in practice since sometimes the codec information will get lost (e.g. replaced with the raw/0x55 codec). + +### Copyright + +Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/). diff --git a/routing/ROUTING_V1_HTTP.md b/routing/ROUTING_V1_HTTP.md index 4d2891785..38e4514fc 100644 --- a/routing/ROUTING_V1_HTTP.md +++ b/routing/ROUTING_V1_HTTP.md @@ -64,7 +64,7 @@ Specifications for some transfer protocols are provided in the "Transfer Protoco ## API -### `GET /routing/v1/providers/{CID}` +### `GET /routing/v1/providers/{CID}[?routers=]` #### Response codes @@ -90,6 +90,18 @@ Response limit: 100 providers Each object in the `Providers` list is a *read provider record*. +#### List of Routers + +A list of routers that should be consulted for responses. The specification imposes no constraints on the order by which the results are returned. Implementers are free to return results as they are found. + +If none are provided the backend may decide which ones to use. For a list of known routers see below. + +To select all routers use `?routers=*`. To determine the list of available routers see the `OPTIONS` API below + +### `OPTIONS /routing/v1/providers` + +If supported the server should include a `SUPPORTED_ROUTERS` header key, with the value as the comma separated list of the routing systems supported. + ## Pagination This API does not support pagination, but optional pagination can be added in a backwards-compatible spec update. @@ -173,3 +185,9 @@ Specification: [ipfs/go-graphsync/blob/main/docs/architecture.md](https://github - `PieceCID`: the CID of the [piece](https://spec.filecoin.io/systems/filecoin_files/piece/#section-systems.filecoin_files.piece) within which the data is stored - `VerifiedDeal`: whether the deal corresponding to the data is verified - `FastRetrieval`: whether the provider claims there is an unsealed copy of the data available for fast retrieval + +## Known Routers + +This section contains a non-exhaustive list of known routers that may be supported by clients and servers. + +- "ipfs-public-dht" - The IPFS Public DHT corresponding to the libp2p protocol ID `/ipfs/kad/1.0.0`