Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower healthcheck interval #10392

Open
3 tasks done
viperey opened this issue Apr 9, 2024 · 1 comment
Open
3 tasks done

Lower healthcheck interval #10392

viperey opened this issue Apr 9, 2024 · 1 comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization

Comments

@viperey
Copy link

viperey commented Apr 9, 2024

Checklist

  • My issue is specific & actionable.
  • I am not suggesting a protocol enhancement.
  • I have searched on the issue tracker for my issue.

Description

Could it be useful to lower the healthcheck interval?
From: HEALTHCHECK --interval=30s --timeout=3s --start-period=5s --retries=3 \
To: HEALTHCHECK --interval=5s --timeout=3s --start-period=5s --retries=20 \

Rationale: If you have a service that has IPFS/Kubo as dependency, about 15/20s of boot time get added for every fresh deployment.

This is not an impactful case for production cases, but pre-production & CI cases might see some improvement. In my personal case, I've already seen that gain when using a modified version of Kubo with these settings.
I might be missing something, but I cannot see many drawbacks to have a high interval value, although this could be due to missing some deep internal elements of a DAG resolution at boot time.

PS: if required & desired, I could do the PR myself, although I guess first it's better to agree here about going forward with this change.

Best.

@viperey viperey added the kind/enhancement A net-new feature or improvement to an existing feature label Apr 9, 2024
@hsanjuan hsanjuan added the need/triage Needs initial labeling and prioritization label Nov 8, 2024
@hsanjuan
Copy link
Contributor

hsanjuan commented Nov 8, 2024

I don't see why not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants