Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS resource on non-IPFS page tries to redirect to https://cid.ipfs.localhost:8080 #1324

Open
Jontes-Tech opened this issue Jun 8, 2024 · 2 comments
Labels
need/author-input Needs input from the original author need/triage Needs initial labeling and prioritization

Comments

@Jontes-Tech
Copy link

Jontes-Tech commented Jun 8, 2024

Describe the bug
A clear and concise description of what the bug is.
In chromium, http://localhost:8080/ipfs/cid redirects to https://cid.ipfs.localhost:8080. Kubo's gateway only serves HTTP, not HTTPS.

To Reproduce
Steps to reproduce the behavior:

  1. Create an HTML (over HTTP) file.
  2. Create an <img> pointing to https://ipfs.io/ipfs/any-cid-here
  3. Image will fail to load because it tries to redirect to https on 8080.

Expected behavior
A clear and concise description of what you expected to happen.
Image loads successfully

Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot from 2024-06-08 15-17-04

Desktop (please complete the following information):

  • OS: Arch Linux
  • Browser: Chromium and Google's "Chrome" rebrand
  • Version: Latest versions on Chrome Web Store.
@Jontes-Tech Jontes-Tech added the need/triage Needs initial labeling and prioritization label Jun 8, 2024
@lidel
Copy link
Member

lidel commented Jun 13, 2024

@Jontes-Tech I was unable to reproduce in fresh install on Chrome 126.0.6478.36

@ipfs ipfs deleted a comment from welcome bot Jun 13, 2024
@lidel lidel added the need/author-input Needs input from the original author label Jun 13, 2024
@Jontes-Tech
Copy link
Author

Yeah, sorry. Github stripped away my HTML tags. I've edited the message to make it clearer.

Basically http://localhost:8080/ipfs/cid should redirect to http://cid.ipfs.localhost:8080 but instead redirects to https://cid.ipfs.localhost:8080 when served as an image in an HTTPS context.

One example of this is present on the following webpage: https://ens.page/jontes.eth

You will see in the network tab how IPFS companion redirects to https:// on localhost.

See the screenshots I've attached:
image
image

Reproducible on both Chrome and Chromium, 125.0.6422.141 (Official Build) Arch Linux (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author need/triage Needs initial labeling and prioritization
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants