From 21ef20cd05e4d0231d0e3d7d2cfbd21fb75b78a2 Mon Sep 17 00:00:00 2001 From: Marcin Rataj Date: Mon, 27 May 2024 10:46:55 +0200 Subject: [PATCH] fix: do not depend on external domains in dnslink tests (#547) Dependency on third-party domains means that over time CI will break, like it did in https://github.com/ipfs/kubo/actions/runs/9214249430/job/25364989609?pr=10429#step:9:63 Error: queryCname ENODATA singularity.storage There three domains left here are enough to cover all cases. Ideally, CI would not depend on internet DNS, and have static fixtures and custom localhost DNS server, but this should be good enough to stop breaking Kubo CI etc --- packages/interop/src/ipns-dnslink.spec.ts | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/packages/interop/src/ipns-dnslink.spec.ts b/packages/interop/src/ipns-dnslink.spec.ts index d8570f725..339084e05 100644 --- a/packages/interop/src/ipns-dnslink.spec.ts +++ b/packages/interop/src/ipns-dnslink.spec.ts @@ -7,17 +7,9 @@ import type { IPNS } from '@helia/ipns' import type { HeliaLibp2p } from 'helia' const TEST_DOMAINS: string[] = [ - 'ipfs.io', + 'ipfs.tech', 'docs.ipfs.tech', - 'en.wikipedia-on-ipfs.org', - 'blog.libp2p.io', - 'consensuslab.world', - 'n0.computer', - 'protocol.ai', - 'research.protocol.ai', - 'probelab.io', - 'singularity.storage', - 'saturn.tech' + 'en.wikipedia-on-ipfs.org' ] describe('@helia/ipns - dnslink', () => {