Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: badRequestResponse is being called incorrectly #27

Closed
SgtPooki opened this issue Mar 21, 2024 · 0 comments · Fixed by #44
Closed

bug: badRequestResponse is being called incorrectly #27

SgtPooki opened this issue Mar 21, 2024 · 0 comments · Fixed by #44
Assignees
@SgtPooki

Comments

@SgtPooki
Copy link
Member

some methods are calling it with badRequestResponse('Invalid IPNS name') which is obfuscating errors because the function signature is actually (url: string, body?: SupportedBodyTypes, init?: ResponseInit)

The function signature was updated to (url: string, body?: SupportedBodyTypes | Error, init?: ResponseInit) in #26
@SgtPooki SgtPooki self-assigned this Apr 8, 2024
@SgtPooki SgtPooki linked a pull request Apr 8, 2024 that will close this issue
fix: pass url and body to badRequestResponse #44
Merged
3 tasks
@SgtPooki SgtPooki mentioned this issue Apr 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pass url and body to badRequestResponse ipfs/helia-verified-fetch
1 participant
@SgtPooki