Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test #130 #131

Open
Stebalien opened this issue Oct 26, 2018 · 1 comment
Open

Test #130 #131

Stebalien opened this issue Oct 26, 2018 · 1 comment
Assignees
@djdv

Comments

@Stebalien
Copy link
Member

This:

  1. Needs a test. Is it possible to test this on non-windows machines?
  2. Needs to be commented.
@djdv
Copy link
Contributor

djdv commented Oct 27, 2018

But if we add tests, how will I pad my commit history?!

Serious:
With the coreapi being a reliable thing now, I'm going to look into designing tests around it that run on the Windows CI.

I'm also going to dedicate some time looking at this again
ipfs/kubo#5224
The building and testing experience on Windows has been pretty well ironed out, but our CI environment needs some refactoring itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djdv djdv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @djdv