Skip to content

Commit

Permalink
add datastore sync measurements
Browse files Browse the repository at this point in the history
  • Loading branch information
aschmahmann committed Dec 3, 2019
1 parent 142e5cb commit 4bdddbf
Showing 1 changed file with 16 additions and 1 deletion.
17 changes: 16 additions & 1 deletion measure.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ func New(prefix string, ds datastore.Datastore) *measure {
putSize: metrics.New(prefix+".put.size_bytes",
"Size distribution of stored byte slices").Histogram(datastoreSizeBuckets),

syncNum: metrics.New(prefix+".sync_total", "Total number of Datastore.Sync calls").Counter(),
syncErr: metrics.New(prefix+".sync.errors_total", "Number of errored Datastore.Sync calls").Counter(),
syncLatency: metrics.New(prefix+".sync.latency_seconds",
"Latency distribution of Datastore.Sync calls").Histogram(datastoreLatencyBuckets),

getNum: metrics.New(prefix+".get_total", "Total number of Datastore.Get calls").Counter(),
getErr: metrics.New(prefix+".get.errors_total", "Number of errored Datastore.Get calls").Counter(),
getLatency: metrics.New(prefix+".get.latency_seconds",
Expand Down Expand Up @@ -106,6 +111,10 @@ type measure struct {
putLatency metrics.Histogram
putSize metrics.Histogram

syncNum metrics.Counter
syncErr metrics.Counter
syncLatency metrics.Histogram

getNum metrics.Counter
getErr metrics.Counter
getLatency metrics.Histogram
Expand Down Expand Up @@ -174,7 +183,13 @@ func (m *measure) Put(key datastore.Key, value []byte) error {
}

func (m *measure) Sync(prefix datastore.Key) error {
return nil
defer recordLatency(m.syncLatency, time.Now())
m.syncNum.Inc()
err := m.backend.Sync(prefix)
if err != nil {
m.syncErr.Inc()
}
return err
}

func (m *measure) Get(key datastore.Key) (value []byte, err error) {
Expand Down

0 comments on commit 4bdddbf

Please sign in to comment.