Skip to content
This repository has been archived by the owner on Aug 12, 2020. It is now read-only.

Mixed imports #48

Closed
ComSecNinja opened this issue Apr 3, 2016 · 1 comment
Closed

Mixed imports #48

ComSecNinja opened this issue Apr 3, 2016 · 1 comment

Comments

@ComSecNinja
Copy link

I tried to explain this but it proved nearly impossible to do so in a manner I could even comprehend myself. Hence, an example:
github.com/ipfs/go-libp2p/p2p/peer/peer.go imports gx/ipfs/.../go-multihash as mh and gx/ipfs/.../go-ipfs-util as u. In block.go line 22 Block expects gx/ipfs/.../go-multihash.Multihash but u.Hash returns github.com/jbenet/go-multihash.Multihash. There are multiple conflicts of this kind out there, of which I list those known to me here:

  • github.com/ipfs/go-ipfs/blocks
  • github.com/ipfs/go-libp2p/p2p/net/swarm/addr
  • github.com/ipfs/go-libp2p/p2p/net/filter
  • github.com/ipfs/go-libp2p/p2p/nat
  • gx/ipfs/QmSN2ELGRp4T9kjqiSsSNJRUeR9JKXzQEgwe1HH3tdSGbC/go-libp2p/p2p/net/swarm/addr
  • github.com/ipfs/go-libp2p/p2p/net/transport
  • github.com/ipfs/go-ipfs/thirdparty/testutil

A complete dump of errors when running go get in examples/api/service, as per my conversation with @whyrusleeping at freenode#ipfs.

@ghost
Copy link

ghost commented Oct 28, 2016

Yeah, we need to go through all examples and make sure they're up-to-date and work :(

Closing in favor of #67

@ghost ghost closed this as completed Oct 28, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant