Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a cargo-udeps check function to mkLib #705

Open
eureka-cpu opened this issue Sep 20, 2024 · 2 comments
Open

Consider adding a cargo-udeps check function to mkLib #705

eureka-cpu opened this issue Sep 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@eureka-cpu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Problem: A common issue is large dependency graphs with unused dependencies that get lost in it. This is especially true for workspaces and monorepos.

Describe the solution you'd like
I'd like to add a function that runs a check using cargo-udeps to report to a user that they have dependencies that are not being used.

Describe alternatives you've considered
I could write my own drv and add it to checks using the cargoCommand from mkLib, but I figured I'd ask here first if it's something that the project would consider.

@eureka-cpu eureka-cpu added the enhancement New feature or request label Sep 20, 2024
@eureka-cpu
Copy link
Contributor Author

I'm happy to take on the work to get this functioning as well

@ipetkov
Copy link
Owner

ipetkov commented Sep 22, 2024

Hi @eureka-cpu, I'd be willing to accept a PR that adds support for cargo-udeps!

IIRC cargo-udeps still requires using a nightly toolchain, but we don't need to go as far as trying to detect whether the toolchain is nightly or not; just let the command fail as it would and it should signal to the user to double check their toolchain. Besides that can't think of any other issues that might get in the way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants