fix: Fix blobHash collision #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howjmay
force-pushed
the
blob-collision
branch
3 times, most recently
from
373c479 to
47b2eac
Compare
|
The python code to generate the hash value to compare in this PR import hashlib
import codecs
# byte string to be converted
b_string = b'\x04\x00\x00\x00'
# decoding the byte string to unicode string
u_string = codecs.decode(b_string, 'utf-8')
text = u_string+"key0"+"val0"+u_string+"key1"+"val1"
print(u_string)
hashObject = hashlib.blake2b(text.encode('utf-8'), digest_size=32)
digest = hashObject.hexdigest()
print(digest) |
howjmay
force-pushed
the
blob-collision
branch
3 times, most recently
from
4ebfe58 to
84ba2d7
Compare
jorgemmsilva
approved these changes
Sep 19, 2023
| values = append(values, v) | ||
| all = append(all, v) | ||
| all = append(all, []byte(k)) | ||
| binary.LittleEndian.PutUint32(prefix[:], uint32(len(key))) |
There was a problem hiding this comment.
we should leave a comment explaining why we need this 👍
| require.NoError(t, err) | ||
| require.Equal(t, resHash, h.Bytes()) | ||
| }) | ||
| t.Run("with escape separator", func(t *testing.T) { |
There was a problem hiding this comment.
I guess this test doesn't make sense anymore
| ) | ||
|
|
||
| func TestMustGetBlobHash(t *testing.T) { | ||
| t.Run("normal", func(t *testing.T) { |
There was a problem hiding this comment.
we should add a test that asserts the collision doesn't happen anymore, right?
so {"ab", "123"} yields a different hash than {"ab1","23"}
howjmay
force-pushed
the
blob-collision
branch
2 times, most recently
from
34d0a46 to
5d00efc
Compare
howjmay
force-pushed
the
blob-collision
branch
from
5d00efc to
08e1548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.