diff --git a/.github/workflows/_external_rust_tests.yml b/.github/workflows/_external_rust_tests.yml index e787b85f668..cbb6ff968d0 100644 --- a/.github/workflows/_external_rust_tests.yml +++ b/.github/workflows/_external_rust_tests.yml @@ -19,7 +19,6 @@ env: jobs: test: name: Test external crates - if: (!cancelled()) env: # Tests written with #[sim_test] are often flaky if run as #[tokio::test] - this var # causes #[sim_test] to only run under the deterministic `simtest` job, and not the @@ -62,7 +61,6 @@ jobs: check-unused-deps: name: Check Unused Dependencies (${{ matrix.flags }}) - if: (!cancelled()) strategy: matrix: flags: ["--all-features", "--no-default-features"] diff --git a/.github/workflows/_rust.yml b/.github/workflows/_rust.yml index f95a7642424..6c70f122a12 100644 --- a/.github/workflows/_rust.yml +++ b/.github/workflows/_rust.yml @@ -1,10 +1,6 @@ name: Rust -on: - workflow_call: - inputs: - isRust: - type: boolean +on: workflow_call env: CARGO_TERM_COLOR: always @@ -32,8 +28,6 @@ env: jobs: rust-lints: uses: ./.github/workflows/_rust_lints.yml - with: - isRust: ${{ inputs.isRust }} deny: uses: ./.github/workflows/_cargo_deny.yml @@ -65,24 +59,20 @@ jobs: filters: .github/external-crates-filters.yml crates-tests: - if: | - !cancelled() && !failure() && inputs.isRust && github.event.pull_request.draft == false + if: github.event.pull_request.draft == false needs: crates-changes uses: ./.github/workflows/_rust_tests.yml with: changedCrates: ${{ join(fromJson(needs.crates-changes.outputs.components), ' ') }} external-tests: - if: | - !cancelled() && !failure() && inputs.isRust && github.event.pull_request.draft == false + if: github.event.pull_request.draft == false needs: external-changes uses: ./.github/workflows/_external_rust_tests.yml with: changedCrates: ${{ join(fromJson(needs.external-changes.outputs.components), ' ') }} execution-cut: - if: | - !cancelled() && !failure() && inputs.isRust && github.event.pull_request.draft == false - needs: - - rust-lints + if: github.event.pull_request.draft == false + needs: rust-lints uses: ./.github/workflows/_execution_cut.yml diff --git a/.github/workflows/_rust_lints.yml b/.github/workflows/_rust_lints.yml index 43410a38234..02e2ea6c26e 100644 --- a/.github/workflows/_rust_lints.yml +++ b/.github/workflows/_rust_lints.yml @@ -1,10 +1,6 @@ name: Rust lints -on: - workflow_call: - inputs: - isRust: - type: boolean +on: workflow_call concurrency: group: rust-lints-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} @@ -18,7 +14,6 @@ env: jobs: rustfmt: - if: (!cancelled() && inputs.isRust) runs-on: [self-hosted] steps: - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 @@ -28,7 +23,6 @@ jobs: run: cargo +nightly ci-fmt cargo-sort: - if: (!cancelled() && inputs.isRust) runs-on: [self-hosted] steps: - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 @@ -46,9 +40,7 @@ jobs: fi clippy: - if: (!cancelled() && !failure() && inputs.isRust) - needs: - - rustfmt + needs: rustfmt runs-on: [self-hosted] steps: - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 diff --git a/.github/workflows/_rust_tests.yml b/.github/workflows/_rust_tests.yml index 9aeccdffe2d..e781ff2ea97 100644 --- a/.github/workflows/_rust_tests.yml +++ b/.github/workflows/_rust_tests.yml @@ -31,7 +31,6 @@ env: jobs: test: name: Test rust crates - if: (!cancelled()) env: # Tests written with #[sim_test] are often flaky if run as #[tokio::test] - this var # causes #[sim_test] to only run under the deterministic `simtest` job, and not the @@ -67,7 +66,6 @@ jobs: check-unused-deps: name: Check Unused Dependencies (${{ matrix.flags }}) - if: (!cancelled()) strategy: matrix: flags: ["--all-features", "--no-default-features"] diff --git a/.github/workflows/hierarchy.yml b/.github/workflows/hierarchy.yml index c5def7a8b1b..45efa02e7ca 100644 --- a/.github/workflows/hierarchy.yml +++ b/.github/workflows/hierarchy.yml @@ -60,7 +60,7 @@ jobs: group: license-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} cancel-in-progress: true needs: diff - if: (!cancelled() && needs.diff.outputs.isRust == 'true') + if: needs.diff.outputs.isRust == 'true' runs-on: [self-hosted] steps: - uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1 @@ -69,12 +69,12 @@ jobs: docusaurus: needs: diff - if: (!cancelled() && needs.diff.outputs.isDoc == 'true' && !github.event.pull_request.draft) + if: needs.diff.outputs.isDoc == 'true' && !github.event.pull_request.draft uses: ./.github/workflows/_docusaurus.yml docs-lint: needs: diff - if: (!cancelled() && needs.diff.outputs.isDoc == 'true') + if: needs.diff.outputs.isDoc == 'true' uses: ./.github/workflows/_docs_lint.yml turborepo: @@ -90,7 +90,6 @@ jobs: - license-check - typos if: | - !cancelled() && !failure() && needs.diff.outputs.isRust == 'false' && needs.diff.outputs.isMove == 'true' && github.event.pull_request.draft == false @@ -102,11 +101,8 @@ jobs: - dprint-format - license-check - typos - if: (!cancelled() && !failure()) + if: needs.diff.outputs.isRust == 'true' uses: ./.github/workflows/_rust.yml - secrets: inherit - with: - isRust: ${{ needs.diff.outputs.isRust == 'true' }} rosetta: needs: @@ -120,7 +116,7 @@ jobs: uses: ./.github/workflows/_rosetta.yml e2e: - if: (!cancelled() && !failure() && (!github.event.pull_request.draft || github.ref_name == 'develop')) + if: (!github.event.pull_request.draft || github.ref_name == 'develop') needs: - diff - dprint-format @@ -136,7 +132,6 @@ jobs: isGraphQlTransport: ${{ needs.diff.outputs.isGraphQlTransport == 'true' }} vercel-deploy: - if: (!cancelled() && !failure()) needs: - diff - dprint-format @@ -153,7 +148,7 @@ jobs: isWalletDashboard: ${{ needs.diff.outputs.isWalletDashboard == 'true' }} ledgernano: - if: (!cancelled() && !failure()) && needs.diff.outputs.isLedgerjs == 'true' && github.event.pull_request.draft == false + if: needs.diff.outputs.isLedgerjs == 'true' && github.event.pull_request.draft == false needs: - diff - dprint-format @@ -163,10 +158,30 @@ jobs: secrets: inherit move-ide: - if: (!cancelled() && !failure()) && needs.diff.outputs.isExternalCrates == 'true' && github.event.pull_request.draft == false + if: needs.diff.outputs.isExternalCrates == 'true' && github.event.pull_request.draft == false needs: - diff - dprint-format - license-check - typos uses: ./.github/workflows/_move_ide.yml + + hierarchy-complete: + if: (!cancelled() && !failure()) + runs-on: [self-hosted] + needs: + - diff + - dprint-format + - license-check + - typos + - docusaurus + - docs-lint + - turborepo + - move-tests + - rust + - e2e + - vercel-deploy + - ledgernano + - move-ide + steps: + - run: echo "Hierarchy Complete"