Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize bindings address generation test #30

Closed
3 tasks done
kwek20 opened this issue Mar 23, 2023 · 2 comments · Fixed by #1336
Closed
3 tasks done

Harmonize bindings address generation test #30

kwek20 opened this issue Mar 23, 2023 · 2 comments · Fixed by #1336
Assignees
@kwek20
Labels
b-all Bindings - All m-wallet Module - Wallet t-test Task - Test
Milestone
v1.1.0

Comments

@kwek20
Copy link
Contributor

kwek20 commented Mar 23, 2023

Task description

For #73 we added address generation tests to bindings.
However each binding uses a different seed/mnemonic.

Requirements

equal address generation asserts across all bindings

Acceptance criteria

equal address generation asserts across all bindings

Creation checklist

  • I have assigned this task to the correct people
  • I have added the most appropriate labels
  • I have linked the correct milestone and/or project
@kwek20 kwek20 added b-java b-nodejs Bindings - Nodejs b-python Bindings - Python b-wasm Bindings - Wasm m-wallet Module - Wallet t-test Task - Test labels Mar 23, 2023
@kwek20 kwek20 self-assigned this Mar 23, 2023
@thibault-martinez thibault-martinez changed the title [Task]: Harmonize bindings address generation test Harmonize bindings address generation test Mar 24, 2023
@thibault-martinez thibault-martinez added b-all Bindings - All and removed b-java b-nodejs Bindings - Nodejs b-python Bindings - Python b-wasm Bindings - Wasm labels Mar 27, 2023
@thibault-martinez thibault-martinez moved this to Product Backlog in iota-sdk Mar 27, 2023
@thibault-martinez thibault-martinez added this to the v1.1.0 milestone Mar 27, 2023
@Thoralf-M
Copy link
Member

In Rust and Python we use test_vectors.json, so only nodejs needs to be updated to this
https://github.com/search?q=repo%3Aiotaledger%2Fiota-sdk%20test_vectors&type=code

@thibault-martinez thibault-martinez moved this from Product Backlog to Sprint Backlog in iota-sdk Sep 19, 2023
@kwek20 kwek20 moved this from Sprint Backlog to In Progress in iota-sdk Sep 25, 2023
@kwek20 kwek20 mentioned this issue Sep 27, 2023
Merged
@kwek20 kwek20 moved this from In Progress to In Review in iota-sdk Sep 27, 2023
@kwek20 kwek20 linked a pull request Sep 27, 2023 that will close this issue
feat/node: Test vectors address test #1336
Merged
@thibault-martinez
Copy link
Member

Closed by #1336

@github-project-automation github-project-automation bot moved this from In Review to Done in iota-sdk Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwek20 kwek20

Labels
b-all Bindings - All m-wallet Module - Wallet t-test Task - Test
Projects
iota-sdk
Status: Done
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

feat/node: Test vectors address test kwek20/iota-sdk
3 participants
@kwek20 @thibault-martinez @Thoralf-M