diff --git a/bindings/core/src/method_handler/client.rs b/bindings/core/src/method_handler/client.rs index 53f65631cd..206250670d 100644 --- a/bindings/core/src/method_handler/client.rs +++ b/bindings/core/src/method_handler/client.rs @@ -259,7 +259,7 @@ pub(crate) async fn call_client_method_internal(client: &Client, method: ClientM } ClientMethod::GetOutputsIgnoreErrors { output_ids } => { let outputs_response = client - .get_outputs_with_metadata_ignore_errors(&output_ids) + .get_outputs_with_metadata_ignore_not_found(&output_ids) .await? .iter() .map(OutputWithMetadataResponse::from) diff --git a/sdk/src/client/node_api/core/mod.rs b/sdk/src/client/node_api/core/mod.rs index ade26cf22a..dffd4b78da 100644 --- a/sdk/src/client/node_api/core/mod.rs +++ b/sdk/src/client/node_api/core/mod.rs @@ -31,9 +31,9 @@ impl Client { futures::future::try_join_all(output_ids.iter().map(|id| self.get_output(id))).await } - /// Requests outputs by their output ID in parallel, ignoring failed requests. + /// Requests outputs by their output ID in parallel, ignoring outputs not found. /// Useful to get data about spent outputs, that might not be pruned yet. - pub async fn get_outputs_ignore_errors(&self, output_ids: &[OutputId]) -> Result> { + pub async fn get_outputs_ignore_not_found(&self, output_ids: &[OutputId]) -> Result> { Ok( futures::future::join_all(output_ids.iter().map(|id| self.get_output(id))) .await @@ -48,8 +48,8 @@ impl Client { futures::future::try_join_all(output_ids.iter().map(|id| self.get_output_metadata(id))).await } - /// Requests metadata for outputs by their output ID in parallel, ignoring failed requests. - pub async fn get_outputs_metadata_ignore_errors(&self, output_ids: &[OutputId]) -> Result> { + /// Requests metadata for outputs by their output ID in parallel, ignoring outputs not found. + pub async fn get_outputs_metadata_ignore_not_found(&self, output_ids: &[OutputId]) -> Result> { Ok( futures::future::join_all(output_ids.iter().map(|id| self.get_output_metadata(id))) .await @@ -64,9 +64,9 @@ impl Client { futures::future::try_join_all(output_ids.iter().map(|id| self.get_output_with_metadata(id))).await } - /// Requests outputs and their metadata by their output ID in parallel, ignoring failed requests. + /// Requests outputs and their metadata by their output ID in parallel, ignoring outputs not found. /// Useful to get data about spent outputs, that might not be pruned yet. - pub async fn get_outputs_with_metadata_ignore_errors( + pub async fn get_outputs_with_metadata_ignore_not_found( &self, output_ids: &[OutputId], ) -> Result> { diff --git a/sdk/src/wallet/operations/syncing/mod.rs b/sdk/src/wallet/operations/syncing/mod.rs index abbbbb4d4e..f5bab33d1b 100644 --- a/sdk/src/wallet/operations/syncing/mod.rs +++ b/sdk/src/wallet/operations/syncing/mod.rs @@ -119,7 +119,7 @@ where log::debug!("[SYNC] spent_or_not_synced_outputs: {spent_or_not_synced_output_ids:?}"); let spent_or_unsynced_output_metadata_responses = self .client() - .get_outputs_metadata_ignore_errors(&spent_or_not_synced_output_ids) + .get_outputs_metadata_ignore_not_found(&spent_or_not_synced_output_ids) .await?; // Add the output response to the output ids, the output response is optional, because an output could be diff --git a/sdk/src/wallet/operations/syncing/outputs.rs b/sdk/src/wallet/operations/syncing/outputs.rs index 85461ce33d..5b540ffe7d 100644 --- a/sdk/src/wallet/operations/syncing/outputs.rs +++ b/sdk/src/wallet/operations/syncing/outputs.rs @@ -222,7 +222,7 @@ pub(crate) async fn get_inputs_for_transaction_payload( .collect::>(); client - .get_outputs_with_metadata_ignore_errors(&output_ids) + .get_outputs_with_metadata_ignore_not_found(&output_ids) .await .map_err(|e| e.into()) }